Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Move from mocks to stubs #1324

Merged
merged 2 commits into from
Aug 6, 2024
Merged

chore: Move from mocks to stubs #1324

merged 2 commits into from
Aug 6, 2024

Conversation

rakesh-garimella
Copy link
Contributor

@rakesh-garimella rakesh-garimella commented Aug 6, 2024 •
edited by skhalash
Loading

Description

Changes proposed in this pull request (what was done and why):

  • In an effort to migrate away from mocks use stubs for daemonset_prober and deployment_prober

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@rakesh-garimella rakesh-garimella added kind/chore Categorizes issue or PR as related to a chore. area/manager Manager or module changes labels Aug 6, 2024
@rakesh-garimella rakesh-garimella requested a review from a team as a code owner August 6, 2024 06:55
@rakesh-garimella rakesh-garimella added this to the 1.22.0 milestone Aug 6, 2024
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 6, 2024
@skhalash skhalash changed the title chore: move from mocks to stubs chore: Move from mocks to stubs Aug 6, 2024
@skhalash skhalash self-assigned this Aug 6, 2024
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 6, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 6, 2024
@kyma-bot kyma-bot merged commit 795ba92 into kyma-project:main Aug 6, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skhalash skhalash skhalash approved these changes

Assignees

@skhalash skhalash

Labels
area/manager Manager or module changes cla: yes Indicates the PR's author has signed the CLA. kind/chore Categorizes issue or PR as related to a chore. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rakesh-garimella @skhalash @kyma-bot