-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support multiple certificates for the ca certificate #270
Merged
kyma-bot
merged 11 commits into
kyma-project:main
from
nesmabadr:support_multiple_certificates
May 10, 2024
Merged
feat: Support multiple certificates for the ca certificate #270
kyma-bot
merged 11 commits into
kyma-project:main
from
nesmabadr:support_multiple_certificates
May 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edcbfff
to
27d7508
Compare
63ce7f0
to
112a0b6
Compare
112a0b6
to
1589c46
Compare
f3c0a56
to
256feb1
Compare
256feb1
to
eccfcae
Compare
9805bb6
to
3d12362
Compare
3d12362
to
2c3bd5b
Compare
2c3bd5b
to
c018316
Compare
runtime-watcher/internal/cacertificatehandler/ca_certificate_handler_test.go
Outdated
Show resolved
Hide resolved
runtime-watcher/internal/cacertificatehandler/ca_certificate_handler_test.go
Outdated
Show resolved
Hide resolved
runtime-watcher/internal/cacertificatehandler/ca_certificate_handler_test.go
Outdated
Show resolved
Hide resolved
runtime-watcher/internal/cacertificatehandler/ca_certificate_handler_test.go
Outdated
Show resolved
Hide resolved
Tomasz-Smelcerz-SAP
requested changes
May 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at my comments
2d807ef
to
814968c
Compare
runtime-watcher/internal/cacertificatehandler/ca_certificate_handler_test.go
Outdated
Show resolved
Hide resolved
runtime-watcher/internal/cacertificatehandler/ca_certificate_handler_test.go
Show resolved
Hide resolved
runtime-watcher/internal/cacertificatehandler/ca_certificate_handler_test.go
Outdated
Show resolved
Hide resolved
814968c
to
6ac0850
Compare
6ac0850
to
4c1a60a
Compare
runtime-watcher/internal/cacertificatehandler/ca_certificate_handler_test.go
Show resolved
Hide resolved
Tomasz-Smelcerz-SAP
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
Resolves #264