Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support multiple certificates for the ca certificate #270

Merged
merged 11 commits into from
May 10, 2024

Conversation

nesmabadr
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Support multiple certificates for the ca certificate

Related issue(s)
Resolves #264

@nesmabadr nesmabadr added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 3, 2024
@nesmabadr nesmabadr requested a review from a team as a code owner May 3, 2024 11:03
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 3, 2024
@nesmabadr nesmabadr added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 3, 2024
@nesmabadr nesmabadr force-pushed the support_multiple_certificates branch 3 times, most recently from edcbfff to 27d7508 Compare May 3, 2024 12:30
@nesmabadr nesmabadr force-pushed the support_multiple_certificates branch 4 times, most recently from 63ce7f0 to 112a0b6 Compare May 3, 2024 13:27
@nesmabadr nesmabadr force-pushed the support_multiple_certificates branch from 112a0b6 to 1589c46 Compare May 3, 2024 13:33
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 3, 2024
@nesmabadr nesmabadr force-pushed the support_multiple_certificates branch 2 times, most recently from f3c0a56 to 256feb1 Compare May 3, 2024 14:36
@nesmabadr nesmabadr force-pushed the support_multiple_certificates branch from 256feb1 to eccfcae Compare May 3, 2024 15:06
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 3, 2024
@nesmabadr nesmabadr force-pushed the support_multiple_certificates branch 2 times, most recently from 9805bb6 to 3d12362 Compare May 6, 2024 13:31
@nesmabadr nesmabadr removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2024
@nesmabadr nesmabadr force-pushed the support_multiple_certificates branch from 3d12362 to 2c3bd5b Compare May 6, 2024 13:43
@nesmabadr nesmabadr force-pushed the support_multiple_certificates branch from 2c3bd5b to c018316 Compare May 6, 2024 13:46
Copy link
Member

@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at my comments

@nesmabadr nesmabadr force-pushed the support_multiple_certificates branch 3 times, most recently from 2d807ef to 814968c Compare May 10, 2024 09:35
@nesmabadr nesmabadr force-pushed the support_multiple_certificates branch from 814968c to 6ac0850 Compare May 10, 2024 13:00
@nesmabadr nesmabadr force-pushed the support_multiple_certificates branch from 6ac0850 to 4c1a60a Compare May 10, 2024 13:02
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 10, 2024
@kyma-bot kyma-bot merged commit 12a07bd into kyma-project:main May 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Support for multiple certificates in the ca-certificates data
3 participants