feat: Add release workflow #166
Conversation
kyma-bot
added
the
size/L
| workflow_dispatch: | ||
| inputs: | ||
| name: | ||
| description: 'Existing tag for the new release' | ||
| default: "" | ||
| required: true |
There was a problem hiding this comment.
Why not let it automatically trigger it when a new tag get pushed like:
name: CI
on:
push:
tags:
- 'v[0-9]+.[0-9]+.[0-9]+' # matches on tags like v1.2.3
And the instead Check if docker image exists we would wait until this image is build with a certain timeout like 15min. So not fail directly when image is not found, but retry with final timeout.
What do you think? I think this should also work and thus we do not need a manual trigger for each release and no check if the tag which was provided exists.
There was a problem hiding this comment.
The reason I did not went into "full automation" is exactly what you mentioned: Waiting for the image to be built, error handling, etc.
If a new tag is created and prowjob fails to build the image, or builts it AFTER the timeout configured here, then what? We have to remove the tag and re-create it? This should also be described in "How to do the release". And so on.
I decided this way (I implemented it now) is most robust. Yes, it's not fully automatic. But there's nothing that can go wrong, it's either success or failure and you don't have to "rollback" anything.
Let's discuss this further, I am not saying my approach is the best one - It just reflects my personal bias towards "foolproof" solutions, even if they require a bit manual effort.
| - name: Check if source code tag exists | ||
| run: | | ||
| if ! [ $(git tag -l ${{ inputs.name }}) ]; then | ||
| echo "::error ::Tag ${{ inputs.name }} doesn't exist" | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
As mentioned in other comment, I would appreciate if we could do everything automatically since this also only checks if the tags exists, but not if that is the actual wanted release. One more point of failure.
If the manual trigger is needed, then ok I think this step is not other possible :(
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| LAST_RELEASE_TAG: ${{ needs.validate-release.outputs.last_release_tag }} | ||
| run: | | ||
| echo "Generating changelog from version: ${{ inputs.name }} to version: $LAST_RELEASE_TAG" |
There was a problem hiding this comment.
This sound confusing, I suggest something simpler like:
echo "Generating changelog for version: ${{ inputs.name }}"
Tomasz-Smelcerz-SAP
force-pushed
the
feat-add_release_action
branch
from
8561338 to
010fc64
Compare
kyma-bot
added
area/documentation
Tomasz-Smelcerz-SAP
force-pushed
the
feat-add_release_action
branch
from
9f7fb8c to
6fb039e
Compare
Description
Add release workflow to the project.
Changes proposed in this pull request:
Related issue(s)
#134