feat: Introduce goreleaser #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
kyma-bot
added
the
size/M
Tomasz-Smelcerz-SAP
force-pushed
the
feat_introduce_goreleaser
branch
from
f00aaef to
3faecf6
Compare
kyma-bot
added
size/L
kyma-bot
removed
the
do-not-merge/work-in-progress
runtime-watcher/.goreleaser.yml
Outdated
Comment on lines
19
to
21
| ignore: | ||
| - goos: darwin | ||
| goarch: 386 |
There was a problem hiding this comment.
If we remove darwin from goos, then this can also be deleted
runtime-watcher/.goreleaser.yml
Outdated
Comment on lines
30
to
32
| format_overrides: | ||
| - goos: windows | ||
| format: zip |
There was a problem hiding this comment.
Same here, if we remove windows, then we do not need any overrides
runtime-watcher/.goreleaser.yml
Outdated
Comment on lines
40
to
60
| groups: | ||
| - title: Bug fixes | ||
| regexp: '^.*?fix(\([[:word:]]+\))??!?:.+$' | ||
| order: 1 | ||
| - title: Dependencies | ||
| regexp: '^.*?deps(\([[:word:]]+\))??!?:.+$' | ||
| order: 2 | ||
| - title: Documentation | ||
| regexp: '^.*?docs(\([[:word:]]+\))??!?:.+$' | ||
| order: 3 | ||
| - title: Test suites | ||
| regexp: '^.*?test(\([[:word:]]+\))??!?:.+$' | ||
| order: 4 | ||
| - title: Features | ||
| order: 0 | ||
| filters: | ||
| exclude: | ||
| - "^docs:" | ||
| - "^test:" | ||
| - '^(B|b)ump' | ||
| - '^.*?chore(\([[:word:]]+\))??!?:.+$' |
There was a problem hiding this comment.
Does not make sense to have a Documentation section, but exclude it - Thus remove the exclude statement or remove the docu group. But I would say keep the docu group and remove the exclusion. Same goes for testing.
Suggested change
| groups: | |
| - title: Bug fixes | |
| regexp: '^.*?fix(\([[:word:]]+\))??!?:.+$' | |
| order: 1 | |
| - title: Dependencies | |
| regexp: '^.*?deps(\([[:word:]]+\))??!?:.+$' | |
| order: 2 | |
| - title: Documentation | |
| regexp: '^.*?docs(\([[:word:]]+\))??!?:.+$' | |
| order: 3 | |
| - title: Test suites | |
| regexp: '^.*?test(\([[:word:]]+\))??!?:.+$' | |
| order: 4 | |
| - title: Features | |
| order: 0 | |
| filters: | |
| exclude: | |
| - "^docs:" | |
| - "^test:" | |
| - '^(B|b)ump' | |
| - '^.*?chore(\([[:word:]]+\))??!?:.+$' | |
| groups: | |
| - title: Bug fixes | |
| regexp: '^.*?fix(\([[:word:]]+\))??!?:.+$' | |
| order: 1 | |
| - title: Dependencies | |
| regexp: '^.*?deps(\([[:word:]]+\))??!?:.+$' | |
| order: 2 | |
| - title: Documentation | |
| regexp: '^.*?docs(\([[:word:]]+\))??!?:.+$' | |
| order: 3 | |
| - title: Test suites | |
| regexp: '^.*?test(\([[:word:]]+\))??!?:.+$' | |
| order: 4 | |
| - title: Features | |
| order: 0 | |
| filters: | |
| exclude: | |
| - '^(B|b)ump' | |
| - '^.*?chore(\([[:word:]]+\))??!?:.+$' |
There was a problem hiding this comment.
I took it verbatim from the CLI project. Perhaps we should adjust it there too, then?
runtime-watcher/hack/release.sh
Outdated
| get_new_release_version | ||
| get_previous_release_version | ||
| # release watcher with release notes generated by goreleaser | ||
| curl -sL https://git.io/goreleaser | VERSION=v1.17.2 bash -s -- |
There was a problem hiding this comment.
Lets directly use latest one
Suggested change
| curl -sL https://git.io/goreleaser | VERSION=v1.17.2 bash -s -- | |
| curl -sL https://git.io/goreleaser | VERSION=v1.21.2 bash -s -- |
kyma-bot
added
size/M
nesmabadr
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds goreleaser configuration and related Makefile target to enable releasing from a dedicated prowjob.
Changes proposed in this pull request:
Related issue(s)
See: #134