Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support spec.info #90

Merged
merged 28 commits into from
Nov 4, 2024
Merged

feat: Support spec.info #90

merged 28 commits into from
Nov 4, 2024

Conversation

lindnerby
Copy link
Member

Description

Changes proposed in this pull request:

  • Add scaffold for info fields: Resources, Documentation and list of Icons
  • Add support to ModuleTemplate creation adding:
spec:
  info:
    repository: <link>
    documentation: <link>
    icons:
    - name: <string>
      link: <link>

Related issue(s)

@lindnerby lindnerby requested a review from a team as a code owner October 30, 2024 07:11
@lindnerby lindnerby linked an issue Oct 30, 2024 that may be closed by this pull request
[ModuleCatalog] Support .spec.info #55
Closed
9 tasks
@kyma-bot kyma-bot added size/XL and removed size/L labels Oct 30, 2024
nesmabadr
nesmabadr reviewed Oct 30, 2024
View reviewed changes
internal/service/contentprovider/moduleconfig.go Outdated Show resolved Hide resolved
scaffold-module-config.yaml Outdated Show resolved Hide resolved
@lindnerby lindnerby requested a review from a team as a code owner October 31, 2024 07:17
@lindnerby lindnerby requested a review from nesmabadr November 4, 2024 08:17
@lindnerby lindnerby requested a review from nesmabadr November 4, 2024 09:48
@kyma-bot kyma-bot added the lgtm label Nov 4, 2024
@lindnerby lindnerby merged commit 17493ed into kyma-project:main Nov 4, 2024
9 checks passed
@lindnerby lindnerby deleted the spec-info branch November 4, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmitoraj mmitoraj mmitoraj approved these changes

@nesmabadr nesmabadr nesmabadr approved these changes

Assignees

@nesmabadr nesmabadr

@mmitoraj mmitoraj

Labels
cla: yes lgtm size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ModuleCatalog] Support .spec.info
4 participants
@lindnerby @nesmabadr @mmitoraj @kyma-bot