feat: Support adding Manager to moduletemplate #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nesmabadr
force-pushed
the
add_manager
branch
4 times, most recently
from
ce3dfce to
20bcfcb
Compare
nesmabadr
force-pushed
the
add_manager
branch
from
20bcfcb to
b321b21
Compare
c-pius
reviewed
Oct 17, 2024
nesmabadr
force-pushed
the
add_manager
branch
3 times, most recently
from
e224704 to
7a5df26
Compare
nesmabadr
force-pushed
the
add_manager
branch
from
2e82e4a to
080c260
Compare
c-pius
previously approved these changes
Oct 18, 2024
nesmabadr
force-pushed
the
add_manager
branch
2 times, most recently
from
9e76587 to
163c684
Compare
nesmabadr
force-pushed
the
add_manager
branch
from
163c684 to
b2b7064
Compare
nesmabadr
force-pushed
the
add_manager
branch
from
b2b7064 to
c2cae6b
Compare
This reverts commit 7eb5d8b.
nesmabadr
force-pushed
the
add_manager
branch
3 times, most recently
from
4544758 to
5ffb07f
Compare
nesmabadr
force-pushed
the
add_manager
branch
from
5ffb07f to
b9a210a
Compare
c-pius
approved these changes
Oct 18, 2024
7 tasks
c-pius
pushed a commit
to c-pius/modulectl
that referenced
this pull request
Oct 21, 2024
* Bump lifecycle manager api and add manager commented to scaffold-create-config.yaml * Add Manager to moduleconfig and unit test * E2E test * Make namespace optional * Replace ocm with 0.16.0 * linting * add e2e test * Chris' comments * Test with namespace empty * Revert "Test with namespace empty" This reverts commit 7eb5d8b. * Test with namespace empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
#57