Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Shorten config flag #71

Merged
merged 3 commits into from
Oct 18, 2024
Merged

feat: Shorten config flag #71

merged 3 commits into from
Oct 18, 2024

Conversation

lindnerby
Copy link
Member

@lindnerby lindnerby commented Oct 16, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Change flag from --module-config-file to --config-file since context is already modulectl
  • Add shorthand flag -c
  • Adapt tests

Related issue(s)

@lindnerby lindnerby requested review from a team as code owners October 16, 2024 15:01
@kyma-bot kyma-bot added size/L and removed size/M labels Oct 16, 2024
@lindnerby lindnerby enabled auto-merge (squash) October 16, 2024 15:19
@lindnerby lindnerby changed the title refactor: Shorten config flag feat: Shorten config flag Oct 16, 2024
@jeremyharisch jeremyharisch self-assigned this Oct 17, 2024
@kyma-bot kyma-bot added the lgtm label Oct 17, 2024
@lindnerby lindnerby merged commit d2a1d78 into kyma-project:main Oct 18, 2024
11 checks passed
@lindnerby lindnerby assigned lindnerby and unassigned mmitoraj and jeremyharisch Oct 21, 2024
@c-pius c-pius mentioned this pull request Oct 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyharisch jeremyharisch jeremyharisch approved these changes

@mmitoraj mmitoraj mmitoraj approved these changes

Assignees

@lindnerby lindnerby

Labels
cla: yes lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lindnerby @mmitoraj @jeremyharisch @kyma-bot