feat: Implement the modulectl create command #49
Conversation
nesmabadr
force-pushed
the
implement_create_module
branch
7 times, most recently
from
c309470 to
75ece5b
Compare
nesmabadr
force-pushed
the
implement_create_module
branch
from
75ece5b to
c2482f3
Compare
nesmabadr
force-pushed
the
implement_create_module
branch
from
c2482f3 to
edfaf2b
Compare
…y exists in the moduleconfig file)
nesmabadr
force-pushed
the
implement_create_module
branch
from
434354f to
334b96b
Compare
nesmabadr
force-pushed
the
implement_create_module
branch
8 times, most recently
from
6b1d2c2 to
ed4cefb
Compare
nesmabadr
force-pushed
the
implement_create_module
branch
from
ed4cefb to
ff3fa58
Compare
|
/cla |
|
Successfully reached out to cla-assistant.io to initialize recheck of PR #49 |
nesmabadr
force-pushed
the
implement_create_module
branch
from
3487d22 to
a541a62
Compare
| return resources, nil | ||
| } | ||
|
|
||
| func CreateCredMatchLabels(registryCredSelector string) ([]byte, error) { |
There was a problem hiding this comment.
Have we considered making it a private func and test it from the same package?
| for { | ||
| var res Resource | ||
| err := decoder.Decode(&res) | ||
| if err != nil { | ||
| if err.Error() == "EOF" { | ||
| break | ||
| } | ||
| return "", fmt.Errorf("failed to parse YAML document: %w", err) | ||
| } | ||
|
|
||
| if res.Kind == "CustomResourceDefinition" && res.Spec.Group == group && res.Spec.Names.Kind == kind { | ||
| return res.Spec.Scope, nil | ||
| } | ||
| } |
There was a problem hiding this comment.
I don't understand this for loop. Does decoder.Decode actually change res?
| @@ -1,20 +1,206 @@ | |||
| package create | |||
|
|
|||
| type ModuleConfigService interface{} | |||
There was a problem hiding this comment.
Why are we only at 27% coverage?
| if s.latestCommit != "" { | ||
| return s.latestCommit, nil | ||
| } |
There was a problem hiding this comment.
Just for my understanding, what is the reason for "caching" the latest commit? Also considering the other GetRemoteFitFileContent method where we pass it as argument and not reading it from the property?
| return defaultCRPath, nil | ||
| } | ||
|
|
||
| path := defaultCRPath |
There was a problem hiding this comment.
I think it would be clearer if path is only declared within the if blocks, and at line 199 we return defaultCRPath given that none of the if branches executed.
…g file
Description
Changes proposed in this pull request:
Related issue(s)
#28