Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Error wrapping from newer to older in the error chain #112

Merged
merged 22 commits into from
Nov 29, 2024
Merged

feat: Error wrapping from newer to older in the error chain #112

merged 22 commits into from
Nov 29, 2024

Conversation

medmes
Copy link
Member

@medmes medmes commented Nov 26, 2024

Description
This PR is for the
Changes proposed in this pull request:

  • make the wrapped error from <new>:<old>
  • Fix unit & e2e testing accordingly

Related issue(s)
#105

@medmes medmes requested a review from a team as a code owner November 26, 2024 08:34
@CLAassistant
Copy link

CLAassistant commented Nov 26, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@lindnerby lindnerby linked an issue Nov 26, 2024 that may be closed by this pull request
Wrap errors from newest to oldest #105
Closed
2 tasks
@medmes medmes changed the title Feat error wrapping improvements Fix: error wrapping from <new to old> in the error chain Nov 26, 2024
@medmes medmes changed the title Fix: error wrapping from <new to old> in the error chain feat: error wrapping from <new to old> in the error chain Nov 26, 2024
@medmes
Copy link
Member Author

medmes commented Nov 26, 2024

/retest

@medmes medmes changed the title feat: error wrapping from <new to old> in the error chain feat: error wrapping from newer to older in the error chain Nov 26, 2024
@medmes medmes changed the title feat: error wrapping from newer to older in the error chain feat: Error wrapping from newer to older in the error chain Nov 26, 2024
@nesmabadr
Copy link
Contributor

There are still multiple occurrences of the old error format for example:

These are the ones I checked but I think there are some more missing

nesmabadr
nesmabadr reviewed Nov 28, 2024
View reviewed changes
internal/service/contentprovider/moduleconfig.go Outdated Show resolved Hide resolved
internal/service/contentprovider/moduleconfig.go Outdated Show resolved Hide resolved
internal/service/filegenerator/filegenerator.go Outdated Show resolved Hide resolved
internal/service/filegenerator/reusefilegenerator/reuse_filegenerator.go Outdated Show resolved Hide resolved
internal/service/filegenerator/reusefilegenerator/reuse_filegenerator.go Outdated Show resolved Hide resolved
internal/service/filegenerator/reusefilegenerator/reuse_filegenerator.go Outdated Show resolved Hide resolved
internal/service/scaffold/options.go Outdated Show resolved Hide resolved
internal/service/scaffold/options.go Outdated Show resolved Hide resolved
internal/service/scaffold/options.go Outdated Show resolved Hide resolved
@medmes medmes enabled auto-merge (squash) November 28, 2024 15:30
@medmes medmes requested a review from nesmabadr November 28, 2024 15:32
@medmes medmes requested a review from nesmabadr November 29, 2024 10:44
@medmes medmes requested a review from nesmabadr November 29, 2024 11:17
@medmes medmes merged commit f7b9155 into kyma-project:main Nov 29, 2024
10 checks passed
@kyma-bot kyma-bot added the lgtm label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nesmabadr nesmabadr nesmabadr approved these changes

Assignees

@nesmabadr nesmabadr

Labels
cla: yes lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrap errors from newest to oldest
4 participants
@medmes @CLAassistant @nesmabadr @kyma-bot