changes for the PR comment

kyma-project · Nov 28, 2024 · 7bda025 · 7bda025
1 parent a65f42b
commit 7bda025
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/internal/common/validation/validation.go b/internal/common/validation/validation.go
@@ -117,7 +117,7 @@ func ValidateIsValidHTTPSURL(input string) error {
 func validateSemanticVersion(version string) error {
 	_, err := semver.StrictNewVersion(strings.TrimSpace(version))
 	if err != nil {
-		return fmt.Errorf("opts.ModuleVersion failed to parse as semantic version: %w",
+		return fmt.Errorf("opts.ModuleVersion failed to be parsed as semantic version: %w",
 			commonerrors.ErrInvalidOption)
 	}
 

diff --git a/internal/service/contentprovider/securityconfig.go b/internal/service/contentprovider/securityconfig.go
@@ -40,7 +40,7 @@ func (s *SecurityConfig) validateArgs(args types.KeyValueArgs) error {
 	}
 
 	if value == "" {
-		return fmt.Errorf("%s: %w must not be empty", ArgModuleName, ErrInvalidArg)
+		return fmt.Errorf("%s must not be empty: %w", ArgModuleName, ErrInvalidArg)
 	}
 
 	return nil

diff --git a/internal/service/moduleconfig/reader/moduleconfig_reader_test.go b/internal/service/moduleconfig/reader/moduleconfig_reader_test.go
@@ -103,7 +103,7 @@ func Test_ValidateModuleConfig(t *testing.T) {
 					"module-icon": "https://example.com/path/to/some-icon",
 				},
 			},
-			expectedError: fmt.Errorf("opts.ModuleVersion failed to parse as semantic version: %w", commonerrors.ErrInvalidOption),
+			expectedError: fmt.Errorf("opts.ModuleVersion failed to be parsed as semantic version: %w", commonerrors.ErrInvalidOption),
 		},
 		{
 			name: "invalid module namespace",

diff --git a/internal/service/scaffold/options_test.go b/internal/service/scaffold/options_test.go
@@ -81,7 +81,7 @@ func Test_Validate_Options(t *testing.T) {
 				ModuleVersion: "invalid",
 			},
 			wantErr: true,
-			errMsg:  "opts.ModuleVersion failed to parse as semantic version",
+			errMsg:  "opts.ModuleVersion failed to be parsed as semantic version",
 		},
 		{
 			name: "ModuleConfigFileName is empty",