Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support internal and beta flags in new module metadata #2097

Merged
merged 16 commits into from
Dec 11, 2024
Merged

feat: Support internal and beta flags in new module metadata #2097

merged 16 commits into from
Dec 11, 2024

Conversation

c-pius
Copy link
Contributor

@c-pius c-pius commented Dec 5, 2024 •
edited
Loading

🚧 to be verified if we can also extend our integration tests will be done as a separate PR
Description

Changes proposed in this pull request:

  • introduces beta and internal flags to ModuleReleaseMeta
  • respects the beta and internal flags when syncing ModuleReleaseMeta and its referenced modules to the SKR
  • keeps the sync of ModuleTemplates using old format in it's current way
    • can be removed once we migrated fully
  • determination of what to sync fully covered in unit tests
  • E2E test for syncing module release meta extended with the new cases

Related issue(s)

@c-pius c-pius requested a review from a team as a code owner December 5, 2024 16:05
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 5, 2024
@c-pius c-pius added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed cla: yes Indicates the PR's author has signed the CLA. labels Dec 5, 2024
@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 5, 2024
@c-pius c-pius changed the title feat: Support internal and beta flags in new module metadata feat: Support internal and beta flags in new module metadata Dec 5, 2024
@c-pius c-pius force-pushed the feat/module-release-meta-supports-internal-beta branch from b234b43 to da2e121 Compare December 5, 2024 16:06
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 5, 2024
@c-pius c-pius removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2024
@c-pius c-pius force-pushed the feat/module-release-meta-supports-internal-beta branch from e9e46fd to c39dde3 Compare December 9, 2024 09:17
Tomasz-Smelcerz-SAP
Tomasz-Smelcerz-SAP requested changes Dec 10, 2024
View reviewed changes
internal/remote/remote_catalog.go Outdated Show resolved Hide resolved
internal/remote/remote_catalog.go Outdated Show resolved Hide resolved
internal/remote/remote_catalog.go Outdated Show resolved Hide resolved
internal/remote/remote_catalog.go Outdated Show resolved Hide resolved
internal/remote/remote_catalog.go Outdated Show resolved Hide resolved
internal/remote/remote_catalog.go Show resolved Hide resolved
@c-pius c-pius force-pushed the feat/module-release-meta-supports-internal-beta branch from c39dde3 to 2404dd8 Compare December 10, 2024 09:54
@c-pius c-pius force-pushed the feat/module-release-meta-supports-internal-beta branch from 5cfe2f7 to 694c82f Compare December 10, 2024 11:47
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 11, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Dec 11, 2024
@c-pius c-pius enabled auto-merge (squash) December 11, 2024 08:59
@c-pius c-pius merged commit 8ae668b into kyma-project:main Dec 11, 2024
65 checks passed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 11, 2024
@c-pius c-pius deleted the feat/module-release-meta-supports-internal-beta branch December 11, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP approved these changes

Assignees

@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Module Catalog] Support internal and beta flags for updated module metadata
3 participants
@c-pius @Tomasz-Smelcerz-SAP @kyma-bot