Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Wrap event recorder #1584

Merged
merged 17 commits into from
Jun 3, 2024
Merged

feat: Wrap event recorder #1584

merged 17 commits into from
Jun 3, 2024

Conversation

lindnerby
Copy link
Member

@lindnerby lindnerby commented May 28, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Extract event recording in wrapper to add custom error truncation and interface testability
  • Refactor structure of internal controller pkg and create pkg for each reconciler
  • Remove storing of event recorder in context and retrieve dependency explicitly
  • Add coverage for event internal pkg

Related issue(s)

@lindnerby lindnerby requested a review from a team as a code owner May 28, 2024 07:31
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 28, 2024
@lindnerby lindnerby linked an issue May 28, 2024 that may be closed by this pull request
Wrap EventRecorder #1519
Closed
8 tasks
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 28, 2024
@lindnerby lindnerby changed the title feature: Wrap event recorder feat: Wrap event recorder May 28, 2024
@lindnerby lindnerby requested a review from a team as a code owner May 28, 2024 09:14
nesmabadr
nesmabadr reviewed May 28, 2024
View reviewed changes
cmd/main.go Show resolved Hide resolved
nesmabadr
nesmabadr reviewed May 28, 2024
View reviewed changes
docs/technical-reference/architecture.md Outdated Show resolved Hide resolved
internal/controller/watcher/controller.go Show resolved Hide resolved
internal/controller/watcher/controller.go Outdated Show resolved Hide resolved
internal/event/event_test.go Outdated Show resolved Hide resolved
@lindnerby lindnerby requested a review from nesmabadr May 29, 2024 07:12
nesmabadr
nesmabadr previously approved these changes May 29, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 29, 2024
mmitoraj
mmitoraj reviewed May 29, 2024
View reviewed changes
docs/technical-reference/architecture.md Outdated Show resolved Hide resolved
docs/technical-reference/architecture.md Outdated Show resolved Hide resolved
docs/technical-reference/architecture.md Outdated Show resolved Hide resolved
@lindnerby @mmitoraj
Apply suggestions from code review
3028680 
documentation review

Co-authored-by: Małgorzata Świeca <[email protected]>
@kyma-bot kyma-bot removed the lgtm Looks good to me! label May 29, 2024
@lindnerby lindnerby requested review from mmitoraj and nesmabadr May 29, 2024 12:31
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 31, 2024
@kyma-bot kyma-bot merged commit b1fc52d into kyma-project:main Jun 3, 2024
43 of 44 checks passed
@lindnerby lindnerby deleted the testable-events branch June 4, 2024 13:16
@c-pius c-pius mentioned this pull request Jun 5, 2024
Open
3 tasks
@c-pius c-pius added the area/quality Related to all activites around quality label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmitoraj mmitoraj mmitoraj approved these changes

@nesmabadr nesmabadr nesmabadr approved these changes

Assignees

@nesmabadr nesmabadr

@mmitoraj mmitoraj

Labels
area/quality Related to all activites around quality cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrap EventRecorder
5 participants
@lindnerby @nesmabadr @mmitoraj @c-pius @kyma-bot