Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use consistent fqdn for moduletemplate and update outdated moduletemplate file #1774

Closed
2 tasks done
ruanxin opened this issue Aug 13, 2024 · 1 comment · Fixed by #2103
Closed
2 tasks done

use consistent fqdn for moduletemplate and update outdated moduletemplate file #1774

ruanxin opened this issue Aug 13, 2024 · 1 comment · Fixed by #2103
Assignees

Comments

@ruanxin
Copy link
Contributor

ruanxin commented Aug 13, 2024

Atm, we still have tests use outdated fqdn for kyma-project.io/template-operator moduletemplate, which makes tests difficut to understand and maintain.

e.g:

  1. in test:
    WithArguments(kcpClient, shared.FQDN, "kyma-project.io/template-operator").
  2. in outdated moduletemplate:

AC:

  • replace outdated moduletemplate which use kyma-project.io/template-operator
    - operator_v1beta2_moduletemplate_kcp-module.yaml is used for generate moduletemplate for integeration tests, it should be replaced with moduletemplate_template_operator_v1_regular.yaml
    - operator_v1beta2_moduletemplate_kcp-module-cred-label.yaml is used for testing oci-registry-cred label, update it with new ocm component descriptor (requires a push to oci registry)
    - operator_v1beta2_moduletemplate_kcp-module_updated.yaml is used here, replace it with moduletemplate which is used for e2e test for update test.
    - operator_v1beta2_moduletemplate_ocm.software.v3alpha1.yaml is for testing ocm schema v3alpha1, use kyma cli generate a new version with correct fqdn (requires a push to oci registry)
    - push newly generated artefacts
  • adjust tests which use kyma-project.io/template-operator, replace it with kyma-project.io/module/template-operator, define a const fqdn name for sharing the usage among tests.
@ruanxin ruanxin changed the title use consistent fqdn for moduletemplate use consistent fqdn for moduletemplate and update outdated moduletemplate file Aug 13, 2024
@LeelaChacha LeelaChacha self-assigned this Dec 4, 2024
@LeelaChacha
Copy link
Contributor

  • operator_v1beta2_moduletemplate_kcp-module.yaml already got replaced by v1beta2_template_operator_current_ocm.yaml, which contains the current fqdn
  • operator_v1beta2_moduletemplate_kcp-module_updated.yaml was already removed
  • operator_v1beta2_moduletemplate_ocm.software.v3alpha1.yaml was already removed

LeelaChacha added a commit to LeelaChacha/kyma-lifecycle-manager that referenced this issue Dec 9, 2024
@nesmabadr nesmabadr self-assigned this Dec 9, 2024
@lindnerby lindnerby assigned LeelaChacha and unassigned nesmabadr Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants