Replace Service Catalog references store

[mszostok]

Description

Service Catalog api-server provides the generic subresources on your CR. Service Catalog is using that to store the references.

Unfortunately, this is not supported in CRDs, see CRD docs.

NOTE: It looks like only the ServiceInstance is using that. Here is PR which introduced that.

Solution:

1. Replace sub-resource operation with patch. See POC implementation.

Concerns:

• check if this approach is acceptable, cause it's not replacing whole sub-resource functionality, e.g. the RBAC

AC:

• new approach for storing references is implemented and accepted by Service Catalog team

[mszostok]

problem with the solution from POC is that on Update function u can change the references fields.

Maybe we can drop the UpdateReferences func and use only the Update function?

[mszostok]

Remember about DoD:

• execute make verify and it MUST end without error
• execute make test-unit and it MUST end without error
• execute make format
• check if your changes need to be applied also for svcat. If yes then modify it and then test it also manually. HINT: Create a binary:

  make svcat
  

  generated binary will be placed in bin/svcat/svcat
• finally, always generate a new image and update tag in chart
• finally, test service catalog by installing chart and walkthrough happy path flow both for namespace-scope and cluster-wide brokers. Happy path means creating and deleting all objects.

[mszostok]

see: https://gist.github.com/mszostok/afd9798fc23b8cdf44439837e925b623

[mszostok]

waiting for kyma-incubator/service-catalog#17 to be merged