Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move env vars to json file #274

Merged
merged 36 commits into from
Dec 11, 2024

Conversation

grischperl
Copy link
Collaborator

@grischperl grischperl commented Nov 26, 2024

Description

Changes proposed in this pull request:

  • all variables moved from .env to config.json
  • default location of the config.json
  • if desire to change that location, do so by overriding location with an env-var / .env file: AICORE_HOME
  • deployment supports mounting secret as a volume

Related issue(s)

#197

Copy link

Note(s) for PR Auther:

  • The integration test will be skipped for the PR. You can trigger it manually after adding the label: run-integration-test.
  • The evaluation test will be skipped for the PR. You can trigger it manually after adding the label: evaluation requested.
  • If any changes are made to the evaluation tests data, make sure that the integration tests are working as expected.
  • If any changes are made to how to run the unit tests, make sure to update the steps for unit-tests in the create-release.yml workflow as well.

Note(s) for PR Reviewer(s):

  • Make sure that the integration and evaluation tests are working as expected.

@grischperl grischperl added evaluation requested A PR with this label will trigger the validation workflow. run-integration-test labels Nov 27, 2024
@grischperl grischperl marked this pull request as ready for review November 27, 2024 11:54
@grischperl grischperl requested a review from a team as a code owner November 27, 2024 11:54
@grischperl grischperl requested a review from muralov November 27, 2024 11:54
@grischperl grischperl force-pushed the 197-model-config branch 2 times, most recently from 11cd3e6 to 95e7354 Compare November 27, 2024 15:19
@kyma-bot kyma-bot added size/L and removed size/M labels Nov 27, 2024
@grischperl grischperl removed evaluation requested A PR with this label will trigger the validation workflow. run-integration-test labels Dec 9, 2024
@grischperl grischperl added evaluation requested A PR with this label will trigger the validation workflow. run-integration-test labels Dec 9, 2024
@grischperl grischperl requested a review from a team as a code owner December 11, 2024 13:20
@kyma-bot kyma-bot added the lgtm label Dec 11, 2024
@kyma-bot kyma-bot merged commit a31a76a into kyma-project:main Dec 11, 2024
14 checks passed
@grischperl grischperl deleted the 197-model-config branch December 11, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes evaluation requested A PR with this label will trigger the validation workflow. lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read model configurations dynamically at runtime
4 participants