Sidecar manager #37
Sidecar manager #37
Conversation
kyma-bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
|
kyma-bot
added
the
size/L
kyma-bot
added
size/XL
kyma-bot
added
size/XXL
|
/test all |
| // We want to avoid performing the same action multiple times for a parent if it contains multiple pods that need to be restarted. | ||
| if _, exists := processedActionObjects[action.object.getKey()]; !exists { | ||
| currentWarnings, err := action.run(ctx, c, action.object, logger) | ||
| if err != nil { |
There was a problem hiding this comment.
With the current implementation we fail fast the restarting of all pods once there is an error for any pod.
Do we want to be more resilient? I think we also didn't do it in the implementation in reconciler.
We can log the error and create a restart warning for the pod here or we could do it in each run function.
There was a problem hiding this comment.
Added logging the error without breaking the loop.
|
/test all |
barchw
requested review from
strekm,
dariusztutaj and
videlov
as code owners
kyma-bot
removed
the
do-not-merge/work-in-progress
|
@werdes72: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold |
kyma-bot
added
the
do-not-merge/hold
|
@werdes72 @cnvergence Please approve and unhold if you don't need anything more to do |
werdes72
removed
the
do-not-merge/hold
See: #26