Merge pull request #50 from triffer/pod-field-selector-fake

Add support for pod status.phase field selector in fake client
kyma-project · Jan 11, 2023 · dd37de0 · dd37de0
2 parents 3fedab2 + ec14e86
commit dd37de0
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 6 deletions.
diff --git a/operator/pkg/lib/sidecars/pods/get_test.go b/operator/pkg/lib/sidecars/pods/get_test.go
@@ -23,7 +23,11 @@ func createClientSet(t *testing.T, objects ...client.Object) client.Client {
 	err = v1.AddToScheme(scheme.Scheme)
 	require.NoError(t, err)
 
-	fakeClient := fake.NewClientBuilder().WithScheme(scheme.Scheme).WithObjects(objects...).Build()
+	fakeClient := fake.NewClientBuilder().
+		WithScheme(scheme.Scheme).
+		WithObjects(objects...).
+		WithIndex(&v1.Pod{}, "status.phase", helpers.FakePodStatusPhaseIndexer).
+		Build()
 
 	return fakeClient
 }

diff --git a/operator/pkg/lib/sidecars/test/helpers/fake_client_indexer.go b/operator/pkg/lib/sidecars/test/helpers/fake_client_indexer.go
@@ -0,0 +1,15 @@
+package helpers
+
+import (
+	"fmt"
+	"k8s.io/api/core/v1"
+	"sigs.k8s.io/controller-runtime/pkg/client"
+)
+
+func FakePodStatusPhaseIndexer(object client.Object) []string {
+	p, ok := object.(*v1.Pod)
+	if !ok {
+		panic(fmt.Errorf("indexer function for type %T's status.phase field received object of type %T", v1.Pod{}, object))
+	}
+	return []string{string(p.Status.Phase)}
+}
diff --git a/operator/pkg/lib/sidecars/test/test_client.go b/operator/pkg/lib/sidecars/test/test_client.go
@@ -55,11 +55,15 @@ func newScenario() (*scenario, error) {
 	}
 
 	return &scenario{
-		Client: fake.NewClientBuilder().WithScheme(scheme.Scheme).WithObjects(
-			helpers.FixNamespaceWith(noAnnotationNamespace, nil),
-			helpers.FixNamespaceWith(sidecarEnabledNamespace, map[string]string{"istio-injection": "enabled"}),
-			helpers.FixNamespaceWith(sidecarDisabledNamespace, map[string]string{"istio-injection": "disabled"}),
-		).Build(),
+		Client: fake.NewClientBuilder().
+			WithScheme(scheme.Scheme).
+			WithObjects(
+				helpers.FixNamespaceWith(noAnnotationNamespace, nil),
+				helpers.FixNamespaceWith(sidecarEnabledNamespace, map[string]string{"istio-injection": "enabled"}),
+				helpers.FixNamespaceWith(sidecarDisabledNamespace, map[string]string{"istio-injection": "disabled"}),
+			).
+			WithIndex(&corev1.Pod{}, "status.phase", helpers.FakePodStatusPhaseIndexer).
+			Build(),
 		logger:                     logr.Discard(),
 		injectionNamespaceSelector: SidecarEnabled,
 	}, nil