Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kustomize templates to fix and align with helm kcp charts #64

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Update kustomize templates to fix and align with helm kcp charts #64

merged 1 commit into from
Dec 15, 2023

Conversation

koala7659
Copy link
Contributor

@koala7659 koala7659 commented Dec 12, 2023 •
edited
Loading

  • Removing prefix to not generate wrong names in make install command to avoid names like compass-compass-manager-le-role
  • Removing unnecessary kustomize files for webhook and certmanager
  • Makefile fix with for role name

@koala7659 koala7659 requested a review from a team as a code owner December 12, 2023 14:20
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 12, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 15, 2023
@kyma-bot kyma-bot merged commit 326dbdd into kyma-project:main Dec 15, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m00g3n m00g3n m00g3n approved these changes

Assignees

@m00g3n m00g3n

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koala7659 @m00g3n @kyma-bot