Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Covering in Go unit tests #6

Merged
merged 2 commits into from
Apr 17, 2023
Merged

Covering in Go unit tests #6

merged 2 commits into from
Apr 17, 2023

Conversation

mvshao
Copy link
Contributor

@mvshao mvshao commented Apr 11, 2023

Description

Changes proposed in this pull request:

  • generate cover for unit test using go test -cover command

Related issue(s)

@mvshao mvshao requested a review from a team as a code owner April 11, 2023 12:54
@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 11, 2023
VOID404
VOID404 reviewed Apr 12, 2023
View reviewed changes
Makefile Show resolved Hide resolved
@mvshao @VOID404
Update Makefile
5538561 
Co-authored-by: Wojciech Nawa <[email protected]>
@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 12, 2023
@mvshao
Copy link
Contributor Author

mvshao commented Apr 12, 2023

/retest

@Ressetkk
Copy link

/cla-recheck

@kyma-bot kyma-bot merged commit 00766cb into kyma-project:main Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VOID404 VOID404 VOID404 approved these changes

Assignees

@VOID404 VOID404

Labels
lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mvshao @Ressetkk @VOID404 @kyma-bot