Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #38

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Update README.md #38

merged 2 commits into from
Oct 27, 2023

Conversation

mvshao
Copy link
Contributor

@mvshao mvshao commented Oct 26, 2023

Description

Add necessary information about Compass Manager
Changes proposed in this pull request:

  • ...
  • ...
  • ...

Related issue(s)

@mvshao mvshao added the area/application-connector Issues or PRs related to application connectivity label Oct 26, 2023
@mvshao mvshao requested a review from a team as a code owner October 26, 2023 08:07
@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 26, 2023
@VOID404
Copy link
Contributor

VOID404 commented Oct 26, 2023

We could describe installation too, it's something like one secret and one make command, right?

@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 26, 2023
VOID404
VOID404 approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@VOID404 VOID404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add that the image has to be configured in the deployment
Also, since you have "Access to k8s cluster" I think k3d is redundant

Other than that this works, and I think it's possible to run it with this guide already, and we'll be adding more precise dev docs later anyway (hopefully), so this is more than fine for now - feel free to unhold

/hold

@kyma-bot kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 26, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 26, 2023
@mvshao
Copy link
Contributor Author

mvshao commented Oct 27, 2023

The image value in deployment file is edited while running make deploy target.

deploy: manifests kustomize
	cd config/manager && $(KUSTOMIZE) edit set image controller=${IMG}
	$(KUSTOMIZE) build config/default | kubectl apply -f -

@mvshao mvshao removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 27, 2023
@kyma-bot kyma-bot merged commit 10d6039 into main Oct 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VOID404 VOID404 VOID404 approved these changes

Assignees

@VOID404 VOID404

Labels
area/application-connector Issues or PRs related to application connectivity lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvshao @VOID404 @kyma-bot