Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scaffolding for the Compass-manager #2

Merged
merged 7 commits into from
Apr 5, 2023
Merged

Scaffolding for the Compass-manager #2

merged 7 commits into from
Apr 5, 2023

Conversation

mvshao
Copy link
Contributor

@mvshao mvshao commented Mar 31, 2023

Description

Changes proposed in this pull request:

  • initial scaffolding of the compass-manager, generated using kubebuilder v3 API

@mvshao mvshao added the area/application-connector Issues or PRs related to application connectivity label Mar 31, 2023
@mvshao mvshao requested a review from a team as a code owner March 31, 2023 12:51
@CLAassistant
Copy link

CLAassistant commented Mar 31, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@kyma-bot kyma-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 31, 2023
VOID404
VOID404 reviewed Apr 3, 2023
View reviewed changes
config/default/kustomization.yaml Outdated
Comment on lines 12 to 13
#commonLabels:
# someName: someValue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add a label, like app=compass-manager or smth

VOID404 and others added 2 commits April 3, 2023 11:32
@VOID404
Add empty folders
b316c83 
`api/` and `controllers/` are needed for the docker build
@mvshao
Label with name
db2a5b0
@VOID404
Copy link
Contributor

VOID404 commented Apr 3, 2023

/test void404_test_of_prowjob_pre-main-compass-manager-trivy

@kyma-bot
Copy link
Contributor

kyma-bot commented Apr 3, 2023

@VOID404: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pre-compass-manager-validate-inrepo-prow-configs
  • /test pull-compass-manager-pjconfigtest
  • /test pull-compass-manager-pjtester
  • /test pull-compass-manager-vpathguard

The following commands are available to trigger optional jobs:

  • /test pre-compass-manager-presubmit-scanner

Use /test all to run the following jobs that were automatically triggered:

  • pre-compass-manager-presubmit-scanner

In response to this:

/test void404_test_of_prowjob_pre-main-compass-manager-trivy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

VOID404
VOID404 reviewed Apr 4, 2023
View reviewed changes
Makefile Outdated
@@ -0,0 +1,157 @@

# Image URL to use all building/pushing image targets
IMG ?= controller:latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default name could be a bit more specific?

Suggested change
IMG ?= controller:latest
IMG ?= compass-manager:latest

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compass-manager-controller? 😛
compass-controller?

@kyma-bot
Copy link
Contributor

kyma-bot commented Apr 4, 2023 •
edited
Loading

@mvshao: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
void404_test_of_prowjob_pre-main-compass-manager-lint 5ecc604 link false /test pre-main-compass-manager-lint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 5, 2023
@kyma-bot kyma-bot merged commit 3f0e757 into kyma-project:main Apr 5, 2023
@mvshao mvshao mentioned this pull request Jul 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VOID404 VOID404 VOID404 approved these changes

Assignees

@VOID404 VOID404

Labels
area/application-connector Issues or PRs related to application connectivity lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mvshao @CLAassistant @VOID404 @kyma-bot