Compass-Manager: Increase reconciliation requeue time when kubeconfig is missing #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
cla: yes
kyma-bot
added
size/S
kyma-bot
added
size/L
koala7659
changed the title
Disper
reviewed
Mar 25, 2024
| @@ -151,8 +154,8 @@ func (cm *CompassManagerReconciler) Reconcile(ctx context.Context, req ctrl.Requ | |||
|
|
|||
| // Kubeconfig doesn't exist / is empty | |||
| if isNotFound(err) || len(kubeconfig) == 0 { | |||
| cm.Log.Infof("Kubeconfig for Kyma resource %s not available.", req.Name) | |||
| return ctrl.Result{RequeueAfter: cm.requeueTime}, nil | |||
| cm.Log.Infof("Kubeconfig for Kyma resource %s not available. Next attempt in 3 minutes", req.Name) | |||
There was a problem hiding this comment.
Next attempt in 3 minutes will be false if the requeueTimeForKubeconfig is changed to a different value.
Could it be changed e.g. to use the current requeueTimeForKubeconfig?
koala7659
changed the title
Disper
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Kubeconfig for reconcilled Kyma reosource is missing - the reconciliation ends and is scheduled again after
requeueTime.This kubecofing secret might just yet not be created by KIM and we need just to wait for it.
But from the other side this may cause that reconciliation is endlessly processed for Kymas when kubeconfig secret is missing permanetly.
To avoid service overload the decission is to increase the requeue time in such a case from 5 seconds into 3 minutes.
Additionally