Skip to content

Commit

Permalink
[Compass Manager] The new URL to Compass System on DEV (#92)
Browse files Browse the repository at this point in the history
<!-- Thank you for your contribution. Before you submit the pull
request:
1. Follow contributing guidelines, templates, the recommended Git
workflow, and any related documentation.
2. Read and submit the required Contributor Licence Agreements
(https://github.com/kyma-project/community/blob/main/CONTRIBUTING.md#agreements-and-licenses).
3. Test your changes and attach their results to the pull request.
4. Update the relevant documentation.

If the pull request requires a decision, follow the [decision-making
process](https://github.com/kyma-project/community/blob/main/governance.md)
and replace the PR template with the [decision record
template](https://github.com/kyma-project/community/blob/main/.github/ISSUE_TEMPLATE/decision-record.md).
-->

**Description**
CMP team are changing URLs, we need to align our components

Changes proposed in this pull request:

- change the default (DEV) URL to Compass
- CM will be using the new Compass secret (needs to be created by SRE)

**Related issue(s)**
#91
  • Loading branch information
kyma-bot authored Jan 23, 2024
2 parents ca1630d + 1cff1a0 commit b1cef59
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions config/manager/manager.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ spec:
- name : APP_ENABLED_REGISTRATION
value: "true"
- name: APP_DIRECTOR_URL
value: https://compass-gateway-auth-oauth.mps.dev.kyma.cloud.sap/director/graphql
value: https://compass-gateway-auth-oauth.cmp-main.dev.kyma.cloud.sap/director/graphql
ports:
- containerPort: 8080
name: metrics
Expand Down Expand Up @@ -76,7 +76,7 @@ spec:
volumes:
- name: director-oauth
secret:
secretName: kcp-provisioner-credentials-file
secretName: kcp-provisioner-new-credentials-file
optional: false
serviceAccountName: compass-manager
terminationGracePeriodSeconds: 10
2 changes: 1 addition & 1 deletion main.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ type config struct {
APIEndpoint string `envconfig:"default=/graphql"`
PlaygroundAPIEndpoint string `envconfig:"default=/graphql"`
SkipDirectorCertVerification bool `envconfig:"default=false"`
DirectorURL string `envconfig:"APP_DIRECTOR_URL,default=https://compass-gateway-auth-oauth.mps.dev.kyma.cloud.sap/director/graphql"`
DirectorURL string `envconfig:"APP_DIRECTOR_URL,default=https://compass-gateway-auth-oauth.cmp-main.dev.kyma.cloud.sap/director/graphql"`
DirectorOAuthPath string `envconfig:"APP_DIRECTOR_OAUTH_PATH,default=./dev/director.yaml"`
EnabledRegistration bool `envconfig:"APP_ENABLED_REGISTRATION,default=false"`
DryRun bool `envconfig:"APP_DRYRUN,default=false"`
Expand Down

0 comments on commit b1cef59

Please sign in to comment.