Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust DynamicPageComponent #3445

Merged
merged 10 commits into from
Nov 8, 2024
Merged

fix: adjust DynamicPageComponent #3445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
dcb50a5
fix: adjust dynamicPage
OliwiaGowor Oct 25, 2024
d5a5d31
fix: separate actionsBar
OliwiaGowor Nov 4, 2024
ee8d7a3
fix: fix actions behavior
OliwiaGowor Nov 4, 2024
06c40b3
fix: remove unused
OliwiaGowor Nov 4, 2024
3e16e3f
Merge branch 'ui5-migrate-v2' into ui5-adjust-page-comp
OliwiaGowor Nov 4, 2024
afc773e
fix: fix classNames
OliwiaGowor Nov 4, 2024
adf2ab5
fix: fix empty toolbar & move banners
OliwiaGowor Nov 6, 2024
8852377
Merge branch 'ui5-migrate-v2' into ui5-adjust-page-comp
OliwiaGowor Nov 6, 2024
b6bc90d
fix: fix dependency
OliwiaGowor Nov 6, 2024
11d3a13
fix: remove spacing file
OliwiaGowor Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/shared/ResourceForm/components/ModeSelector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export function ModeSelector({ mode, setMode, isDisabled = false }) {
<SegmentedButton
className="mode-selector__content"
onSelectionChange={event => {
const mode = event.detail.selectedItem.getAttribute('data-mode');
const mode = event.detail.selectedItems[0].getAttribute('data-mode');
setMode(mode);
if (preferencesViewType === 'MODE_DEFAULT') {
setEditViewMode({
Expand Down
3 changes: 3 additions & 0 deletions src/shared/ResourceForm/components/ResourceForm.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ form .resource-form {
box-sizing: border-box;
padding: 0 1rem;

ui5-form-item::part(layout) {
grid-template-columns: none;
}
form {
overflow: hidden;
flex-grow: 1;
Expand Down
Loading
Loading