fix: remove [] for update depth error

kyma-project · Dec 6, 2024 · 208ff59 · 208ff59
1 parent 20d8ad7
commit 208ff59
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 10 deletions.
diff --git a/src/header/NamespaceChooser/NamespaceChooser.tsx b/src/header/NamespaceChooser/NamespaceChooser.tsx
@@ -42,7 +42,7 @@ export function NamespaceChooser() {
     />,
   ];
 
-  allNamespaces.map(ns =>
+  allNamespaces?.map(ns =>
     namespaces.push(
       <SideNavigationSubItem
         text={ns}

diff --git a/src/header/NamespaceDropdown/NamespaceDropdown.tsx b/src/header/NamespaceDropdown/NamespaceDropdown.tsx
@@ -11,7 +11,7 @@ export function NamespaceDropdown() {
 
   let namespaces = [];
 
-  if (allNamespaces.length > 0) {
+  if (allNamespaces && allNamespaces.length > 0) {
     namespaces.push(
       <ComboBoxItem
         text={t('navigation.all-namespaces')}
@@ -21,7 +21,7 @@ export function NamespaceDropdown() {
     );
   }
 
-  allNamespaces.map(ns =>
+  allNamespaces?.map(ns =>
     namespaces.push(<ComboBoxItem text={ns} key={ns} data-key={ns} />),
   );
 

diff --git a/src/hooks/useAvailableNamespaces.ts b/src/hooks/useAvailableNamespaces.ts
@@ -27,8 +27,8 @@ export function useAvailableNamespaces() {
   };
 
   useEffect(() => {
-    if (error && Array.isArray(namespaces) && namespaces.length !== 0) {
-      setNamespaces([]);
+    if (error) {
+      setNamespaces(null);
       return;
     }
     const filteredNamespaces = allNamespaces

diff --git a/src/shared/components/DynamicPageComponent/DynamicPageComponent.js b/src/shared/components/DynamicPageComponent/DynamicPageComponent.js
@@ -352,7 +352,7 @@ export const DynamicPageComponent = ({
         titleArea={headerTitle}
         headerArea={customHeaderContent ?? headerContent}
         selectedSectionId={selectedSectionIdState}
-        onSelectedSectionChange={e => {
+        onBeforeNavigate={e => {
           if (isFormOpen.formOpen) {
             e.preventDefault();
           }
@@ -363,14 +363,14 @@ export const DynamicPageComponent = ({
             isFormOpen,
             setIsFormOpen,
             () => {
-              setSelectedSectionIdState(e.detail.selectedSectionId);
+              setSelectedSectionIdState(e.detail.sectionId);
               setIsResourceEdited({
                 isEdited: false,
               });
             },
           );
 
-          if (e.detail.selectedSectionId === 'edit') {
+          if (e.detail.sectionId === 'edit') {
             setIsFormOpen({ formOpen: true });
           }
         }}

diff --git a/src/state/namespacesAtom.ts b/src/state/namespacesAtom.ts
@@ -1,8 +1,8 @@
 import { atom, RecoilState } from 'recoil';
 
-export type NamespacesState = string[];
+export type NamespacesState = string[] | null;
 
-const defaultValue: string[] = [];
+const defaultValue = null;
 
 export const namespacesState: RecoilState<NamespacesState> = atom<
   NamespacesState