Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing Message Strip #857

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Closing Message Strip #857

merged 2 commits into from
Sep 3, 2024

Conversation

ralikio
Copy link
Member

@ralikio ralikio commented Sep 3, 2024 •
edited
Loading

Description

Added handler that closes Message strip when "x" button is clicked.

Changes proposed in this pull request:

  • added onClose event handler,
  • displaying message from useState property with the same name,
  • clearing message property when MessageStrip should be closed.

Related issue(s)

#442

@ralikio ralikio added the kind/bug Categorizes issue or PR as related to a bug. label Sep 3, 2024
@ralikio ralikio requested a review from a team as a code owner September 3, 2024 09:40
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 3, 2024
@kyma-bot kyma-bot added the area/documentation Issues or PRs related to documentation label Sep 3, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 3, 2024
@ralikio ralikio merged commit 0725906 into kyma-project:sm-integration Sep 3, 2024
11 checks passed
@ralikio ralikio mentioned this pull request Sep 3, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarekMichali MarekMichali MarekMichali approved these changes

Assignees

@MarekMichali MarekMichali

Labels
area/documentation Issues or PRs related to documentation cla: yes Indicates the PR's author has signed the CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ralikio @MarekMichali @kyma-bot