-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected Error Rendering #853
Merged
ralikio
merged 6 commits into
kyma-project:sm-integration
from
ralikio:bugfixes/incorrect-error-rendering
Aug 29, 2024
Merged
Corrected Error Rendering #853
ralikio
merged 6 commits into
kyma-project:sm-integration
from
ralikio:bugfixes/incorrect-error-rendering
Aug 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added service instance id to instance details view, error message after successful instance removal and to instances table for reference.
New error for loading instances so that other error do not hide entire service instances view.
kyma-bot
added
cla: yes
Indicates the PR's author has signed the CLA.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
Aug 29, 2024
MarekMichali
previously approved these changes
Aug 29, 2024
/hold |
kyma-bot
added
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Aug 29, 2024
kyma-bot
added
area/documentation
Issues or PRs related to documentation
and removed
lgtm
Looks good to me!
labels
Aug 29, 2024
MarekMichali
approved these changes
Aug 29, 2024
/unhold |
kyma-bot
removed
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/documentation
Issues or PRs related to documentation
cla: yes
Indicates the PR's author has signed the CLA.
kind/bug
Categorizes issue or PR as related to a bug.
lgtm
Looks good to me!
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
#442