Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected Error Rendering #853

Merged

Conversation

ralikio
Copy link
Member

@ralikio ralikio commented Aug 29, 2024

Description

Changes proposed in this pull request:

  • added service instance id to instance details view, error message after successful instance removal and to instances table for reference,
  • new error for loading instances so that other error do not hide entire service instances view,
  • hide Details on Successful Instance Removal.

Related issue(s)

#442

Added service instance id to instance details view, error message after successful instance removal and to instances table for reference.
New error for loading instances so that other error do not hide entire service instances view.
@ralikio ralikio added the kind/bug Categorizes issue or PR as related to a bug. label Aug 29, 2024
@ralikio ralikio requested a review from a team as a code owner August 29, 2024 12:42
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 29, 2024
MarekMichali
MarekMichali previously approved these changes Aug 29, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 29, 2024
@MarekMichali
Copy link
Contributor

/hold

@kyma-bot kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2024
@kyma-bot kyma-bot added area/documentation Issues or PRs related to documentation and removed lgtm Looks good to me! labels Aug 29, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 29, 2024
@MarekMichali
Copy link
Contributor

/unhold

@kyma-bot kyma-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2024
@ralikio ralikio merged commit bbb315a into kyma-project:sm-integration Aug 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Issues or PRs related to documentation cla: yes Indicates the PR's author has signed the CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants