Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flexible Column Layout for Offerings and Instances Views #850

Merged
merged 9 commits into from
Aug 29, 2024
Merged

Flexible Column Layout for Offerings and Instances Views #850

merged 9 commits into from
Aug 29, 2024

Conversation

ralikio
Copy link
Member

@ralikio ralikio commented Aug 28, 2024

Description

Changes proposed in this pull request:

  • corrected loaders by changing setLoading(true) and setLoading(false) methods order,
  • removed dialogs and introduced Flexible Column Layout to display instance and offerings details,
  • corrected bug of incorrect opening of empty error message.

Related issue(s)

#442

@ralikio ralikio added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 28, 2024
@ralikio ralikio requested a review from a team as a code owner August 28, 2024 14:43
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 28, 2024
@kyma-bot kyma-bot added the area/documentation Issues or PRs related to documentation label Aug 28, 2024
@ralikio ralikio mentioned this pull request Aug 28, 2024
Closed
9 tasks
ralikio added 6 commits August 29, 2024 12:58
@ralikio
Corrected Border Radius and Error Message Margin
1d55184 
Main object page was displaied with rounder bottom corners, which is not compliant with how Busola displays it. Additionally, error message was rendered just at the top of its component withouth any margins.
@ralikio
Removed Unused Imports
4c77edd
@ralikio
UnableToLoad Page Corrections
3181854 
Copied the same mechanics from offerings view for displaying error message when secret data is not able to load hiding main view. Previously, the view for service instances was rendered without any data. Not it is hidden behind error banner.

Added additional error message to UnableToLoad banner to show more detailed message of what has gone wrong.
@ralikio
Unused Import
f49a0d6
@ralikio
Unused Import
af1ef47
@ralikio
Closing Panel on Selected Secret Change
1e238dd
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 29, 2024
@ralikio ralikio merged commit fa5711a into kyma-project:sm-integration Aug 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarekMichali MarekMichali MarekMichali approved these changes

Assignees

@MarekMichali MarekMichali

Labels
area/documentation Issues or PRs related to documentation cla: yes Indicates the PR's author has signed the CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ralikio @MarekMichali @kyma-bot