Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Api State Removal - UI Passing Secret Name and Namespace Params #845

Merged
merged 4 commits into from
Aug 26, 2024
Merged

Api State Removal - UI Passing Secret Name and Namespace Params #845

merged 4 commits into from
Aug 26, 2024

Conversation

ralikio
Copy link
Member

@ralikio ralikio commented Aug 23, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

Related issue(s)

#442

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 23, 2024
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 23, 2024
@ralikio ralikio added kind/bug Categorizes issue or PR as related to a bug. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. labels Aug 23, 2024
@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 23, 2024
@ralikio ralikio force-pushed the features/ui-secret-headers branch from 68a5065 to 05862e5 Compare August 23, 2024 10:52
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 23, 2024
@ralikio ralikio marked this pull request as ready for review August 23, 2024 12:20
@ralikio ralikio requested a review from a team as a code owner August 23, 2024 12:20
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 23, 2024
@kyma-bot kyma-bot added the area/documentation Issues or PRs related to documentation label Aug 26, 2024
MarekMichali
MarekMichali previously approved these changes Aug 26, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 26, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Aug 26, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 26, 2024
@MarekMichali MarekMichali merged commit 31125e5 into kyma-project:sm-integration Aug 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarekMichali MarekMichali MarekMichali approved these changes

Assignees

@MarekMichali MarekMichali

Labels
area/documentation Issues or PRs related to documentation cla: yes Indicates the PR's author has signed the CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ralikio @kyma-bot @MarekMichali