Add hint to press Enter when adding labels to SI #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
cla: yes
9 tasks
ralikio
reviewed
Aug 22, 2024
| @@ -153,6 +153,7 @@ function CreateInstanceForm(props: any) { | |||
| tokens={labels.map(label => <ui5.Token text={label} />)} | |||
| type="Text" | |||
| valueState="None" | |||
| placeholder="After adding a label, press Enter to add another label" | |||
There was a problem hiding this comment.
Can we put "enter" in quotation marks?
ralikio
added
the
do-not-merge/hold
ralikio
previously approved these changes
Aug 22, 2024
|
/unhold |
kyma-bot
removed
the
do-not-merge/hold
ralikio
approved these changes
Aug 22, 2024
ralikio
requested changes
Aug 22, 2024
PK85
approved these changes
Aug 22, 2024
MarekMichali
merged commit 07bfb99
into
kyma-project:sm-integration
9 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
See #442