Broken Connectivity Error Page #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If secrets was not loaded correctly use empty string to showcase it and hide Layout components to block any user action.
setLoading was not invoked correctly with false value when props contained incorrect values. Such implementation resulted in infinite loading indicator.
If mentioned IllustratedMessage is put inside of renderData method then ui5.Menu complains about calling `length` on undefined.
ralikio
added
the
kind/enhancement
kyma-bot
added
cla: yes
9 tasks
MarekMichali
approved these changes
Aug 20, 2024
szwedm
pushed a commit
that referenced
this pull request
Aug 21, 2024
* Conditional Rendering of Navigation and Router Outlet If secrets was not loaded correctly use empty string to showcase it and hide Layout components to block any user action. * Prevent Infinite Loader setLoading was not invoked correctly with false value when props contained incorrect values. Such implementation resulted in infinite loading indicator. * Removed Unnecessary Comments * Move Error Message Outside of the renderData Method If mentioned IllustratedMessage is put inside of renderData method then ui5.Menu complains about calling `length` on undefined. * Moved loadSecrets to useEffect Method * Expand Error Message to Occupy Full Parent Height
kyma-gopher-bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
* Conditional Rendering of Navigation and Router Outlet If secrets was not loaded correctly use empty string to showcase it and hide Layout components to block any user action. * Prevent Infinite Loader setLoading was not invoked correctly with false value when props contained incorrect values. Such implementation resulted in infinite loading indicator. * Removed Unnecessary Comments * Move Error Message Outside of the renderData Method If mentioned IllustratedMessage is put inside of renderData method then ui5.Menu complains about calling `length` on undefined. * Moved loadSecrets to useEffect Method * Expand Error Message to Occupy Full Parent Height
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following PR contains changes coauthored with @MarekMichali that contains error page for broken API connectivity case.
Changes proposed in this pull request: details in commits list.
Related issue(s)
#442