Page Title #817
Merged
Page Title #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added title attribute to Layout component to show information about which view is currently active.
Forced display property to be set to inline instead of grid to allow title `block` placement before the `Secrets` view. Added a 1rem padding to put some space between the title and the top of an ObjectPage.
ralikio
added
the
kind/enhancement
kyma-bot
added
cla: yes
9 tasks
MarekMichali
approved these changes
Aug 19, 2024
szwedm
pushed a commit
that referenced
this pull request
Aug 21, 2024
* Setting Page Title from Within Route Component Added title attribute to Layout component to show information about which view is currently active. * Removing Unnecessary Imports * CSS Update for Object Page Forced display property to be set to inline instead of grid to allow title `block` placement before the `Secrets` view. Added a 1rem padding to put some space between the title and the top of an ObjectPage.
kyma-gopher-bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
* Setting Page Title from Within Route Component Added title attribute to Layout component to show information about which view is currently active. * Removing Unnecessary Imports * CSS Update for Object Page Forced display property to be set to inline instead of grid to allow title `block` placement before the `Secrets` view. Added a 1rem padding to put some space between the title and the top of an ObjectPage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
blockplacement before theSecretsview,Related issue(s)
#442