Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load secrets onClick #809

Merged
merged 4 commits into from
Aug 19, 2024

Conversation

MarekMichali
Copy link
Contributor

@MarekMichali MarekMichali commented Aug 14, 2024

Description

Load secrets onClick "Select secret" to not force the user to reload the page when a new secret is added.

Changes proposed in this pull request:

  • Load secrets onClick
  • Refresh views

Related issue(s)

See #442

@MarekMichali MarekMichali requested a review from a team as a code owner August 14, 2024 05:44
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 14, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 14, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 16, 2024
Copy link
Contributor

@szwedm szwedm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 19, 2024
@MarekMichali MarekMichali merged commit 4ac0574 into kyma-project:sm-integration Aug 19, 2024
12 checks passed
szwedm pushed a commit that referenced this pull request Aug 21, 2024
* Load secrets onClick

* Switch secret

* When pressing button only fetch

* Dynamic instance list
kyma-gopher-bot pushed a commit that referenced this pull request Aug 22, 2024
* Load secrets onClick

* Switch secret

* When pressing button only fetch

* Dynamic instance list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants