-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load secrets onClick #809
Merged
MarekMichali
merged 4 commits into
kyma-project:sm-integration
from
MarekMichali:fetch-secrets
Aug 19, 2024
Merged
Load secrets onClick #809
MarekMichali
merged 4 commits into
kyma-project:sm-integration
from
MarekMichali:fetch-secrets
Aug 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
cla: yes
Indicates the PR's author has signed the CLA.
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
Aug 14, 2024
MarekMichali
force-pushed
the
fetch-secrets
branch
from
August 14, 2024 08:16
210da02
to
c156bb6
Compare
MarekMichali
force-pushed
the
fetch-secrets
branch
from
August 14, 2024 11:18
c156bb6
to
446fe6b
Compare
kyma-bot
added
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
and removed
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
Aug 14, 2024
kyma-bot
added
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
and removed
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
Aug 16, 2024
szwedm
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
9 tasks
szwedm
pushed a commit
that referenced
this pull request
Aug 21, 2024
* Load secrets onClick * Switch secret * When pressing button only fetch * Dynamic instance list
kyma-gopher-bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
* Load secrets onClick * Switch secret * When pressing button only fetch * Dynamic instance list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Load secrets onClick "Select secret" to not force the user to reload the page when a new secret is added.
Changes proposed in this pull request:
Related issue(s)
See #442