Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog and StatusMessage Mechanics Corrections #799

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Dialog and StatusMessage Mechanics Corrections #799

merged 2 commits into from
Aug 8, 2024

Conversation

ralikio
Copy link
Member

@ralikio ralikio commented Aug 8, 2024

Description

Changes proposed in this pull request:

  • corrected mechanics of opening instance details dialog to fix not opening it on a second consecutive click,
  • unwrapped StatusMessage from FormItem,
  • added InstancesView's StatusMessage.

Related issue(s)

#442

@ralikio ralikio requested review from a team as code owners August 8, 2024 07:10
@kyma-bot kyma-bot added the area/documentation Issues or PRs related to documentation label Aug 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 8, 2024
@ralikio ralikio changed the title Features/dialog and status message Dialog and StatusMessage Mechanics Corrections Aug 8, 2024
@kyma-bot kyma-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 8, 2024
@ralikio ralikio changed the base branch from main to sm-integration August 8, 2024 07:10
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 8, 2024
@ralikio ralikio added kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature and removed area/documentation Issues or PRs related to documentation labels Aug 8, 2024
szwedm
szwedm approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@szwedm szwedm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 8, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Aug 8, 2024
szwedm
szwedm approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@szwedm szwedm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 8, 2024
@szwedm szwedm removed the request for review from a team August 8, 2024 08:58
@ralikio ralikio merged commit 1fd312a into kyma-project:sm-integration Aug 8, 2024
11 checks passed
szwedm pushed a commit that referenced this pull request Aug 21, 2024
@ralikio @szwedm
Dialog and StatusMessage Mechanics Corrections (#799)
e6b854c 
Mechanics Corection for Dialog and Status Messages
kyma-gopher-bot pushed a commit that referenced this pull request Aug 22, 2024
@ralikio @kyma-gopher-bot
Dialog and StatusMessage Mechanics Corrections (#799)
4df9f97 
Mechanics Corection for Dialog and Status Messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szwedm szwedm szwedm approved these changes

Assignees

@szwedm szwedm

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ralikio @szwedm @kyma-bot