Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set secret name and namespace from create Service Binding request #794

Merged
merged 3 commits into from
Aug 8, 2024
Merged

Set secret name and namespace from create Service Binding request #794

merged 3 commits into from
Aug 8, 2024

Conversation

szwedm
Copy link
Contributor

@szwedm szwedm commented Aug 7, 2024

Description

Changes proposed in this pull request:

  • include secret's name and namespace in create Service Binding request,
  • create the secret with the data provided by the user,
  • do not create the secret if a namespace is not provided to avoid K8s errors,
  • serialize values from Service Binding's credentials,
  • add unit test for a case when Service Binding contains credentials with JSON object.

Related issue(s)

See #442

@szwedm szwedm requested a review from a team as a code owner August 7, 2024 11:51
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 7, 2024
@szwedm szwedm changed the title Sm integration secret customization Set secret name and namespace from create Service Binding request Aug 7, 2024
@szwedm szwedm mentioned this pull request Aug 7, 2024
Closed
9 tasks
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 8, 2024
@ralikio ralikio added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 8, 2024
@szwedm
Copy link
Contributor Author

szwedm commented Aug 8, 2024

/unhold

@kyma-bot kyma-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 8, 2024
@ralikio ralikio merged commit c8c5803 into kyma-project:sm-integration Aug 8, 2024
14 of 15 checks passed
szwedm added a commit that referenced this pull request Aug 21, 2024
@szwedm
Set secret name and namespace from create Service Binding request (#794)
ac4066a 
* Add secret's name and namespace fields into CreateServiceBinding request

* Set secret's name and namespace based on the request

* Add unit test for POST Service Binding with JSON object in credentials
kyma-gopher-bot pushed a commit that referenced this pull request Aug 22, 2024
@szwedm @kyma-gopher-bot
Set secret name and namespace from create Service Binding request (#794)
beec1ef 
* Add secret's name and namespace fields into CreateServiceBinding request

* Set secret's name and namespace based on the request

* Add unit test for POST Service Binding with JSON object in credentials
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralikio ralikio ralikio approved these changes

Assignees

@ralikio ralikio

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@szwedm @ralikio @kyma-bot