Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of Labels and Parameters Consumption in Create Instance Form #782

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Addition of Labels and Parameters Consumption in Create Instance Form #782

merged 2 commits into from
Aug 6, 2024

Conversation

ralikio
Copy link
Member

@ralikio ralikio commented Aug 6, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • addition of create instance form labels and parameters input,
  • missing Busy Indicators.

Related issue(s)

#442

@ralikio ralikio added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Aug 6, 2024
@ralikio ralikio requested a review from a team as a code owner August 6, 2024 08:56
@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 6, 2024
szwedm
szwedm approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@szwedm szwedm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kyma-bot kyma-bot added lgtm Looks good to me! cla: yes Indicates the PR's author has signed the CLA. labels Aug 6, 2024
@ralikio ralikio merged commit aa50aa3 into kyma-project:sm-integration Aug 6, 2024
12 checks passed
szwedm pushed a commit that referenced this pull request Aug 21, 2024
@ralikio @szwedm
Addition of Labels and Parameters Consumption in Create Instance Form (…
88b9001 
…#782)

* Create Instance Form - Labels and Parameters

* Busy Indicators
kyma-gopher-bot pushed a commit that referenced this pull request Aug 22, 2024
@ralikio @kyma-gopher-bot
Addition of Labels and Parameters Consumption in Create Instance Form (…
5c7439a 
…#782)

* Create Instance Form - Labels and Parameters

* Busy Indicators
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szwedm szwedm szwedm approved these changes

Assignees

@szwedm szwedm

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ralikio @szwedm @kyma-bot