Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polishing List Instances View #780

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Polishing List Instances View #780

merged 1 commit into from
Aug 6, 2024

Conversation

ralikio
Copy link
Member

@ralikio ralikio commented Aug 5, 2024 •
edited
Loading

Description

The following PR contains polishing of List Instances View.

Changes proposed in this pull request:

  • associated router's path '/service-instances/:id` with open dialog on service instances view,
  • button for instance removal,
  • usage of BusyIndicator instead of a deprecated loader,
  • api calls for instance removal,

Related issue(s)

#442

@ralikio ralikio requested a review from a team as a code owner August 5, 2024 13:43
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 5, 2024
@ralikio ralikio added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Aug 5, 2024
@ralikio ralikio changed the title Polishing Create Instance Form Polishing List Instances View Aug 5, 2024
szwedm
szwedm approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@szwedm szwedm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 5, 2024
@ralikio ralikio merged commit b7df487 into kyma-project:sm-integration Aug 6, 2024
15 checks passed
szwedm pushed a commit that referenced this pull request Aug 21, 2024
@ralikio @szwedm
Polishing List Instances View (#780)
0838593 
Polishing Create Instance Form
kyma-gopher-bot pushed a commit that referenced this pull request Aug 22, 2024
@ralikio @kyma-gopher-bot
Polishing List Instances View (#780)
13bfec6 
Polishing Create Instance Form
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szwedm szwedm szwedm approved these changes

Assignees

@szwedm szwedm

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ralikio @szwedm @kyma-bot