Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI Corrections #774

Merged
merged 3 commits into from
Jul 29, 2024
Merged

UI Corrections #774

merged 3 commits into from
Jul 29, 2024

Conversation

ralikio
Copy link
Member

@ralikio ralikio commented Jul 28, 2024 •
edited
Loading

Description

The following PR contains UI corrections for BTP Manager UI. The fixes are centered around tidying layout and removal of unnecessary elements.

Changes proposed in this pull request:

  • removal of unnecessary DOM elements without any purpose,
  • css styles for flex layout and correction of main page layout based on conventions from Busola.
  • introduction of css margin-wrapper for even margin accross entire frontend
  • introduction of ResponsiveGrid for service offerings items,
  • removal of css styles inlined as html attributes,
  • correction of viewport size units (vw and vh) to parent related percentage (%)
  • correction of names for API entites returned for service offerings - catalogName to catalog_name,
  • usage of displayName instead of catalogName in service offerings view,
  • correction boolean comparison in test data switch,
  • header removal - won't be used in Busola,
  • side navigation icons,
  • puzzle image for non service offerings that do not have an image defined,
  • scrolling corrections,
  • added missing column in service instance table.

Related issue(s)

#442

@ralikio ralikio added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Jul 28, 2024
@ralikio ralikio requested a review from a team as a code owner July 28, 2024 20:53
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 28, 2024
@ralikio ralikio mentioned this pull request Jul 28, 2024
Merged
szwedm
szwedm approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@szwedm szwedm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 29, 2024
@szwedm szwedm merged commit 46c6563 into kyma-project:sm-integration Jul 29, 2024
11 checks passed
szwedm pushed a commit that referenced this pull request Aug 21, 2024
@ralikio @szwedm
UI Corrections (#774)
d0445f4 
* UI Unification

* UI Corrections

* API Fields Corrections
kyma-gopher-bot pushed a commit that referenced this pull request Aug 22, 2024
@ralikio @kyma-gopher-bot
UI Corrections (#774)
eed23cf 
* UI Unification

* UI Corrections

* API Fields Corrections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szwedm szwedm szwedm approved these changes

Assignees

@szwedm szwedm

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ralikio @szwedm @kyma-bot