Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ServiceInstanceDetailsView - UI Dialog Mechanics #768

Merged
merged 1 commit into from
Jul 22, 2024
Merged

ServiceInstanceDetailsView - UI Dialog Mechanics #768

merged 1 commit into from
Jul 22, 2024

Conversation

ralikio
Copy link
Member

@ralikio ralikio commented Jul 22, 2024 •
edited
Loading

Description

Mechanics for displaying simple dialog for Service Instances Details view.

Changes proposed in this pull request:

  • New ServiceInstanceDetailsView,
  • moved a dialog from ServiceInstanceView to ServiceInstanceDetailsView,
  • linter and variable names corrections,
  • index correction in test json.

Related issue(s)

#442

@ralikio ralikio added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Jul 22, 2024
@ralikio ralikio requested a review from a team as a code owner July 22, 2024 10:31
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 22, 2024
@ralikio ralikio changed the title Instances Details Dialog ServiceInstanceDetailsView - UI Dialog Mechanics Jul 22, 2024
szwedm
szwedm approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@szwedm szwedm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 22, 2024
@ralikio ralikio merged commit f5f9590 into kyma-project:sm-integration Jul 22, 2024
13 checks passed
szwedm pushed a commit that referenced this pull request Aug 21, 2024
@ralikio @szwedm
ServiceInstanceDetailsView - UI Dialog Mechanics (#768)
4e4e3af 
Instances Details Dialog
kyma-gopher-bot pushed a commit that referenced this pull request Aug 22, 2024
@ralikio @kyma-gopher-bot
ServiceInstanceDetailsView - UI Dialog Mechanics (#768)
17c811b 
Instances Details Dialog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szwedm szwedm szwedm approved these changes

Assignees

@szwedm szwedm

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ralikio @szwedm @kyma-bot