Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possibility to Load Test Data Based on Env Variable #763

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Possibility to Load Test Data Based on Env Variable #763

merged 2 commits into from
Jul 19, 2024

Conversation

ralikio
Copy link
Member

@ralikio ralikio commented Jul 18, 2024 •
edited
Loading

Description

The following PR introduces environment files with environment variable called REACT_APP_USE_TEST_DATA that enables to switch from API calls to usage of test data when testing and demoing BTP Manager UI. See React Docs for detailed description of the mechanism.

Changes proposed in this pull request:

  • new environment variable called REACT_APP_USE_TEST_DATA,
  • conditional API call if REACT_APP_USE_TEST_DATA is set to false,
  • test data in separate file.

Related issue(s)

#442

@ralikio ralikio added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Jul 18, 2024
@ralikio ralikio requested a review from a team as a code owner July 18, 2024 10:32
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 18, 2024
szwedm
szwedm approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@szwedm szwedm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 18, 2024
@ralikio ralikio merged commit ab2fed5 into kyma-project:sm-integration Jul 19, 2024
12 checks passed
szwedm pushed a commit that referenced this pull request Aug 21, 2024
@ralikio @szwedm
Possibility to Load Test Data Based on Env Variable (#763)
ae69e55 
* Switching Between Test Data and API Call

* Extracted Test Data to Separate File
kyma-gopher-bot pushed a commit that referenced this pull request Aug 22, 2024
@ralikio @kyma-gopher-bot
Possibility to Load Test Data Based on Env Variable (#763)
8a73cd1 
* Switching Between Test Data and API Call

* Extracted Test Data to Separate File
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szwedm szwedm szwedm approved these changes

Assignees

@szwedm szwedm

@ralikio ralikio

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ralikio @szwedm @kyma-bot