Handle Service Instances in SM client #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
cla: yes
9 tasks
ukff
approved these changes
Jun 28, 2024
ukff
added
the
kind/enhancement
szwedm
added a commit
that referenced
this pull request
Aug 21, 2024
* rm internal/ from gitignore * Add Operation struct * Add ServiceInstance struct * ServiceInstances path const * Change the field name in collections of SM objects to Items * GET Service Instances * GET Service Instance by ID * Add SI, Error structs for SM responses * POST Service Instance * Refactor http response body reading * DELETE Service Instance * PATCH Service Instance * GET Service Instance params * Add fake SI JSONs for tests * GET Service Instances test * GET Service Instance by ID test * POST Service Instance test * Refactor SM client unit test to use typed structs instead of generic maps * PATCH Service Instance test * DELETE Service Instance by ID test
kyma-gopher-bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
* rm internal/ from gitignore * Add Operation struct * Add ServiceInstance struct * ServiceInstances path const * Change the field name in collections of SM objects to Items * GET Service Instances * GET Service Instance by ID * Add SI, Error structs for SM responses * POST Service Instance * Refactor http response body reading * DELETE Service Instance * PATCH Service Instance * GET Service Instance params * Add fake SI JSONs for tests * GET Service Instances test * GET Service Instance by ID test * POST Service Instance test * Refactor SM client unit test to use typed structs instead of generic maps * PATCH Service Instance test * DELETE Service Instance by ID test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
handle CRUD operations on Service Instances in Service Manager client.
Related issue(s)
See #442