Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Service Bindings in SM client and get Service Instances in API #735

Merged
merged 12 commits into from
Jul 16, 2024
Merged

Handle Service Bindings in SM client and get Service Instances in API #735

merged 12 commits into from
Jul 16, 2024

Conversation

ukff
Copy link
Contributor

@ukff ukff commented Jun 25, 2024 •
edited by ralikio
Loading

@ukff ukff requested a review from a team as a code owner June 25, 2024 12:12
@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 25, 2024
@ralikio ralikio mentioned this pull request Jul 4, 2024
Closed
9 tasks
@szwedm szwedm force-pushed the sm-intergration-4 branch from 219135b to 7df609e Compare July 10, 2024 10:09
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 12, 2024
@szwedm szwedm changed the title wip - Sm integration 4 Handle Service Bindings in SM client and get Service Instances in API Jul 16, 2024
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 16, 2024
szwedm
szwedm approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@szwedm szwedm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 16, 2024
@szwedm
Copy link
Contributor

szwedm commented Jul 16, 2024

/test pull-btp-manager-build

@szwedm szwedm merged commit c00c68f into kyma-project:sm-integration Jul 16, 2024
13 of 14 checks passed
@ralikio ralikio mentioned this pull request Jul 16, 2024
Merged
szwedm added a commit that referenced this pull request Aug 21, 2024
@ukff @szwedm @KsaweryZietara
Handle Service Bindings in SM client and get Service Instances in API (…
6cec48e 
…#735)

* wip

* wip

* wip

* Rebase and sort imports

* wip

* Fix fetching structs fields

* Fix ServiceBinding struct

* GET Service Instances in API

* CRUD Service Bindings

* GET Service Plan by ID in SM client

* GET Service Instance by ID in API

* Revert temp changes

---------

Co-authored-by: Marcin Szwed <[email protected]>
Co-authored-by: Ksawery Zietara <[email protected]>
kyma-gopher-bot pushed a commit that referenced this pull request Aug 22, 2024
@ukff @szwedm
@KsaweryZietara @kyma-gopher-bot
Handle Service Bindings in SM client and get Service Instances in API (…
1714b66 
…#735)

* wip

* wip

* wip

* Rebase and sort imports

* wip

* Fix fetching structs fields

* Fix ServiceBinding struct

* GET Service Instances in API

* CRUD Service Bindings

* GET Service Plan by ID in SM client

* GET Service Instance by ID in API

* Revert temp changes

---------

Co-authored-by: Marcin Szwed <[email protected]>
Co-authored-by: Ksawery Zietara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szwedm szwedm szwedm approved these changes

Assignees

@szwedm szwedm

@KsaweryZietara KsaweryZietara

@ukff ukff

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ukff @szwedm @kyma-bot @KsaweryZietara