Run frontend from go binary #720

szwedm · 2024-06-12T13:04:53Z

Description

Changes proposed in this pull request:

Bundle frontend static files to go binary.

Related issue(s)

kyma-bot · 2024-06-12T13:04:57Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

szwedm · 2024-06-13T06:39:06Z

/test pull-btp-manager-build

szwedm · 2024-06-13T06:44:53Z

/test pull-btp-manager-build

szwedm · 2024-06-13T06:50:02Z

/test pull-btp-manager-build

szwedm · 2024-06-13T09:15:10Z

/hold

Makefile

main.go

IwonaLanger · 2024-06-14T12:01:32Z

docs/contributor/ui.md

+> Use the latest development image to test the UI: europe-docker.pkg.dev/kyma-project/dev/btp-manager:PR-720
+
+Follow steps below to run BTP Manager with UI:
+1. Connect `kubectl` to your cluster by setting `KUBECONFIG` environment variable.


Suggested change

1. Connect `kubectl` to your cluster by setting `KUBECONFIG` environment variable.

1. Connect `kubectl` to your cluster by setting the **KUBECONFIG** environment variable.

Suggestion applied.

IwonaLanger · 2024-06-14T12:02:50Z

docs/contributor/ui.md

+```shell
+export KUBECONFIG=<path-to-kubeconfig>
+```
+2. Make sure `btp-operator` module is disabled and there are no existing BtpOperator custom resources and deployments of BTP Manager and SAP BTP service operator.


Suggested change

2. Make sure `btp-operator` module is disabled and there are no existing BtpOperator custom resources and deployments of BTP Manager and SAP BTP service operator.

2. Make sure the `btp-operator` module is disabled and there are no existing BtpOperator custom resources (CRs) and deployments of BTP Manager and the SAP BTP service operator.

Suggestion applied.

IwonaLanger · 2024-06-14T12:03:10Z

docs/contributor/ui.md

+kubectl get deployment -n kyma-system btp-manager-controller-manager
+kubectl get deployment -n kyma-system sap-btp-operator-controller-manager
+```
+3. Clone `btp-manager` repository and checkout to `sm-integration` branch.


Suggested change

3. Clone `btp-manager` repository and checkout to `sm-integration` branch.

3. Clone the `btp-manager` repository and checkout to the `sm-integration` branch.

Suggestion applied.

IwonaLanger · 2024-06-14T12:03:49Z

docs/contributor/ui.md

+git clone https://github.com/kyma-project/btp-manager.git
+git checkout sm-integration
+```
+4. Set `IMG` environment variable to the image of BTP Manager with UI.


Suggested change

4. Set `IMG` environment variable to the image of BTP Manager with UI.

4. Set the **IMG** environment variable to the image of BTP Manager with UI.

Suggestion applied.

IwonaLanger · 2024-06-14T12:04:29Z

docs/contributor/ui.md

+```shell
+kubectl get deployment -n kyma-system btp-manager-controller-manager
+```
+In case you encounter the following error during Pod creation due to Warden's admission webhook:


Suggested change

In case you encounter the following error during Pod creation due to Warden's admission webhook:

If you encounter the following error during Pod creation due to Warden's admission webhook:

Suggestion applied.

IwonaLanger · 2024-06-14T12:05:30Z

docs/contributor/ui.md

+```
+Error creating: admission webhook "validation.webhook.warden.kyma-project.io" denied the request: Pod images europe-docker.pkg.dev/kyma-project/dev/btp-manager:PR-720 validation failed
+```
+you need to scale BTP Manager deployment to 0 replicas, delete the webhook and the scale deployment back to 1 replica.


Suggested change

you need to scale BTP Manager deployment to 0 replicas, delete the webhook and the scale deployment back to 1 replica.

you must scale the BTP Manager deployment to 0 replicas, delete the webhook, and scale the deployment back to 1 replica.

Suggestion applied.

IwonaLanger · 2024-06-14T12:06:06Z

docs/contributor/ui.md

+kubectl delete validatingwebhookconfigurations.admissionregistration.k8s.io validation.webhook.warden.kyma-project.io
+kubectl scale deployment -n kyma-system btp-manager-controller-manager --replicas=1
+```
+7. Apply BtpOperator custom resource to create the secret with credentials to access Service Manager.


Suggested change

7. Apply BtpOperator custom resource to create the secret with credentials to access Service Manager.

7. Apply BtpOperator CR to create the Secret with credentials to access Service Manager.

Suggestion applied.

IwonaLanger · 2024-06-14T12:08:06Z

docs/contributor/ui.md

+```shell
+export KUBECONFIG=<path-to-kubeconfig>
+```


Please indent the code blocks and other content under each of the steps.

Suggestion applied.

docs/contributor/ui.md

Co-authored-by: Iwona Langer <[email protected]>

ui/src/components/SecretsView.tsx

szwedm · 2024-06-17T10:58:50Z

/unhold

* Serve frontend from go * Build UI static files * Change metrics server port * Add API config fields in deployment * Fix serving API on 8080 port * Add makefile rule to build ui * Change the order of makefile rules * eslint * eslint * Fix dockerfile copy * Add doc describing how to deploy BTP Manager with UI * Fix docs * Add cleanup info, prerequisites info and fix formatting * Typos * Apply suggestions from doc review Co-authored-by: Iwona Langer <[email protected]> * Rename ui.md to 09-10-ui.md --------- Co-authored-by: Iwona Langer <[email protected]>

szwedm added 5 commits June 12, 2024 14:24

Serve frontend from go

4cf4022

Build UI static files

fce2e49

Change metrics server port

9f4b497

Add API config fields in deployment

e43c274

Fix serving API on 8080 port

1a9c45a

kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 12, 2024

kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 12, 2024

szwedm added 4 commits June 12, 2024 16:49

Add makefile rule to build ui

f9d5169

Change the order of makefile rules

69c8a93

eslint

49ba07d

eslint

213310f

Fix dockerfile copy

664e050

szwedm marked this pull request as ready for review June 13, 2024 08:43

szwedm requested a review from a team as a code owner June 13, 2024 08:43

kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 13, 2024

szwedm self-assigned this Jun 13, 2024

kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 13, 2024

ukff reviewed Jun 13, 2024

View reviewed changes

Makefile Show resolved Hide resolved

ukff reviewed Jun 13, 2024

View reviewed changes

main.go Show resolved Hide resolved

Add doc describing how to deploy BTP Manager with UI

ee7677e

szwedm requested a review from a team as a code owner June 14, 2024 10:36

kyma-bot added the area/documentation Issues or PRs related to documentation label Jun 14, 2024

Fix docs

88c8571

szwedm mentioned this pull request Jun 14, 2024

[POC] Catalog Views and integration with Service Manager #442

Closed

9 tasks

IwonaLanger reviewed Jun 14, 2024

View reviewed changes

PK85 previously approved these changes Jun 14, 2024

View reviewed changes

kyma-bot assigned PK85 Jun 14, 2024

kyma-bot added the lgtm Looks good to me! label Jun 14, 2024

Add cleanup info, prerequisites info and fix formatting

a3105d9

szwedm dismissed PK85’s stale review via a3105d9 June 14, 2024 16:43

kyma-bot removed the lgtm Looks good to me! label Jun 14, 2024

Typos

431c2da

IwonaLanger reviewed Jun 17, 2024

View reviewed changes

szwedm and others added 2 commits June 17, 2024 11:05

Apply suggestions from doc review

e11460f

Co-authored-by: Iwona Langer <[email protected]>

Rename ui.md to 09-10-ui.md

517fa97

IwonaLanger approved these changes Jun 17, 2024

View reviewed changes

kyma-bot assigned IwonaLanger Jun 17, 2024

kyma-bot added the lgtm Looks good to me! label Jun 17, 2024

ukff reviewed Jun 17, 2024

View reviewed changes

ui/src/components/SecretsView.tsx Show resolved Hide resolved

ukff approved these changes Jun 17, 2024

View reviewed changes

kyma-bot assigned ukff Jun 17, 2024

kyma-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2024

szwedm merged commit 5adbe6e into kyma-project:sm-integration Jun 17, 2024
13 of 14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run frontend from go binary #720

Run frontend from go binary #720

szwedm commented Jun 12, 2024

kyma-bot commented Jun 12, 2024

szwedm commented Jun 13, 2024

szwedm commented Jun 13, 2024

szwedm commented Jun 13, 2024

szwedm commented Jun 13, 2024

IwonaLanger Jun 14, 2024

szwedm Jun 14, 2024

IwonaLanger Jun 14, 2024

szwedm Jun 14, 2024

IwonaLanger Jun 14, 2024

szwedm Jun 14, 2024

IwonaLanger Jun 14, 2024

szwedm Jun 14, 2024

IwonaLanger Jun 14, 2024

szwedm Jun 14, 2024

IwonaLanger Jun 14, 2024

szwedm Jun 14, 2024

IwonaLanger Jun 14, 2024

szwedm Jun 14, 2024

IwonaLanger Jun 14, 2024

szwedm Jun 14, 2024

szwedm commented Jun 17, 2024

	1. Connect `kubectl` to your cluster by setting `KUBECONFIG` environment variable.
	1. Connect `kubectl` to your cluster by setting the KUBECONFIG environment variable.

	2. Make sure `btp-operator` module is disabled and there are no existing BtpOperator custom resources and deployments of BTP Manager and SAP BTP service operator.
	2. Make sure the `btp-operator` module is disabled and there are no existing BtpOperator custom resources (CRs) and deployments of BTP Manager and the SAP BTP service operator.

	3. Clone `btp-manager` repository and checkout to `sm-integration` branch.
	3. Clone the `btp-manager` repository and checkout to the `sm-integration` branch.

	4. Set `IMG` environment variable to the image of BTP Manager with UI.
	4. Set the IMG environment variable to the image of BTP Manager with UI.

	In case you encounter the following error during Pod creation due to Warden's admission webhook:
	If you encounter the following error during Pod creation due to Warden's admission webhook:

	you need to scale BTP Manager deployment to 0 replicas, delete the webhook and the scale deployment back to 1 replica.
	you must scale the BTP Manager deployment to 0 replicas, delete the webhook, and scale the deployment back to 1 replica.

	7. Apply BtpOperator custom resource to create the secret with credentials to access Service Manager.
	7. Apply BtpOperator CR to create the Secret with credentials to access Service Manager.

Run frontend from go binary #720

Run frontend from go binary #720

Conversation

szwedm commented Jun 12, 2024

kyma-bot commented Jun 12, 2024

szwedm commented Jun 13, 2024

szwedm commented Jun 13, 2024

szwedm commented Jun 13, 2024

szwedm commented Jun 13, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

szwedm commented Jun 17, 2024