Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature toggle for rate limiting #1451

Merged
merged 11 commits into from
Nov 18, 2024
Merged

Feature toggle for rate limiting #1451

merged 11 commits into from
Nov 18, 2024

Conversation

triffer
Copy link
Contributor

@triffer triffer commented Nov 14, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Add new build tag dev_features to avoid the setup of the new RateLimit controller in production images.
  • Use the build tag dev_features for all existing development-related make targets to ensure the rate limit feature is tested.
  • Add prod and dev overlay for kustomize to avoid releasing RateLimit CRD and permission for RateLimit CRD in manager-role ClusterRole.

Pre-Merge Checklist

  • As a PR reviewer, verify code coverage and evaluate if it is acceptable.

Related issues

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 14, 2024
@triffer triffer mentioned this pull request Nov 14, 2024
Closed
12 tasks
@triffer triffer marked this pull request as ready for review November 15, 2024 07:17
@triffer triffer requested a review from a team as a code owner November 15, 2024 07:17
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 15, 2024
videlov
videlov approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@videlov videlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good 👍🏻

@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 18, 2024
@triffer triffer merged commit 7f4b0e8 into kyma-project:main Nov 18, 2024
28 checks passed
@triffer triffer deleted the ratelimit-feature-flag branch November 18, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@videlov videlov videlov approved these changes

Assignees

@videlov videlov

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@triffer @videlov @kyma-bot