This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Add test coverage for webhook #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwalach
approved these changes
Mar 12, 2019
mszostok
added a commit
that referenced
this pull request
May 17, 2019
mszostok
added a commit
that referenced
this pull request
Jun 12, 2019
polskikiel
pushed a commit
that referenced
this pull request
Aug 7, 2019
mszostok
added a commit
that referenced
this pull request
Aug 14, 2019
mszostok
added a commit
that referenced
this pull request
Sep 11, 2019
jasiu001
pushed a commit
to jasiu001/service-catalog
that referenced
this pull request
Sep 23, 2019
… (CRDs) solution (kubernetes-retired#2630) * Add basic validation to crds * Add webhook skeleton, remove api-server from chart, add webhoook server in chart, move PrepareForCreate login into webhook handler (kyma-incubator#2) * Add webhook skeleton, remove api-server from chart, add webhoook server in chart, move PrepareForCreate login into webhook handler * Add logger and GVK matcher * Add test coverage for webhook (kyma-incubator#6) * Add Status entry initialization in binding and instance controller (kyma-incubator#5) * Change fs to label selector (kyma-incubator#9) * Fix removing finalizer after switching to CRD /status sub-resource (kyma-incubator#8) * Add tests to webhooks (kyma-incubator#11) * Replace changevalidator with webhook (kyma-incubator#14) * Replace default service plan with webhook (kyma-incubator#10) * Add tests to webhooks - fix * Rewrite defaultServicePlan feature to webhook * Replace plugins by webhook (kyma-incubator#16) * Replace ServiceBinding plugin by webhook * Replace Broker plugins by webhook * Adjust webhooks to multi validation handlers * Service Catalog going towards to CRDs (kyma-incubator#18) * Migrate registry/strategy Updates to webhooks (kyma-incubator#17) * Use Update instead of updateReference method (kyma-incubator#19) * Replace tableconvertor with APC (kyma-incubator#20) * Fix svcat tests after the rebase with the upstream master branch * Pre delete jobs - remove CRD after delete helm release (kyma-incubator#21) * Apply fixes after executing `make verify` * Create docs about webhook implementation (kyma-incubator#24) * Change the securePort for the webhook server because colidates with old api-server * Change import paths to kubernetes-sigs, and rebase with master * Apply fixes after rebase Fixes: * makefile targets, * instance deprovision operation * entries under additionalPrinterColumns in crds.yaml * unit tests after rebase * Update documentation (kyma-incubator#40) * Update docs * Fix vendor after rebase with k8s 1.15 bump * Apply changes after review - remove the contrib/hack/crd folder - remove reference to Kyma project - rebase with current master - restore the image in chart - extract CRDs defintion to dedicated folder
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a
What this PR does / why we need it:
Which issue(s) this PR fixes