Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

[HOTFIX] Label filtering to respect source and target of FA #3922

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

StanislavStefanov
Copy link
Contributor

While listing resources via label filter gather all of the source IDs and all of the target IDs. We can not rely only on source or only on target as in case of ongoing unassign some participant may be present only as source or only as target.

@StanislavStefanov StanislavStefanov requested a review from a team as a code owner June 26, 2024 11:00
@kyma-bot kyma-bot added 🦖 team-raptor Team Raptor Label do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 26, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jun 26, 2024
@kyma-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivantenevvasilev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyma-bot kyma-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2024
@ognyvrac ognyvrac removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 26, 2024
@kyma-bot kyma-bot merged commit c548cd5 into hotfix-v1.96.2 Jun 26, 2024
7 checks passed
@StanislavStefanov StanislavStefanov deleted the hotfix-labelfilters branch June 26, 2024 12:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files. 🦖 team-raptor Team Raptor Label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants