Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

Fix for failing Operation Controller tests #3909

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Fix for failing Operation Controller tests #3909

merged 2 commits into from
Jun 10, 2024

Conversation

dzahariev
Copy link
Member

@dzahariev dzahariev commented Jun 7, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Fix for failing Operation Controller tests

Pull Request status

  • Implementation
  • Unit tests
  • Integration tests
  • chart/compass/values.yaml is updated
  • Mocks are regenerated, using the automated script

@dzahariev dzahariev requested a review from a team as a code owner June 7, 2024 13:37
@kyma-bot kyma-bot added 🦅 team-falcon Team Falcon Label do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cla: yes Indicates the PR's author has signed the CLA. labels Jun 7, 2024
@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 7, 2024
ognyvrac
ognyvrac reviewed Jun 7, 2024
View reviewed changes
Copy link
Contributor

@ognyvrac ognyvrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to still be broken locally by calling make test-local. Can you change some .go file to trigger the unit tests by Prow?

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jun 10, 2024
@kyma-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: emmakarova, ognyvrac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyma-bot kyma-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2024
@ognyvrac
Copy link
Contributor

/unhold

@kyma-bot kyma-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 10, 2024
@kyma-bot kyma-bot merged commit b7fbb22 into main Jun 10, 2024
3 checks passed
@ognyvrac ognyvrac deleted the dzahariev-patch-1 branch June 10, 2024 09:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ognyvrac ognyvrac ognyvrac approved these changes

@emmakarova emmakarova emmakarova approved these changes

@alextargov alextargov Awaiting requested review from alextargov

Assignees

@emmakarova emmakarova

@ognyvrac ognyvrac

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. 🦅 team-falcon Team Falcon Label lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dzahariev @kyma-bot @ognyvrac @emmakarova