Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

[HOTFIX] Fix processing of jsonpath for SLIS select criteria #3875

Merged
merged 2 commits into from
May 15, 2024

Conversation

emmakarova
Copy link
Contributor

@emmakarova emmakarova commented May 13, 2024

Description
Currently when building the select criteria parameter for the SLIS requests in system fetcher jsonpath is separated by comma only. With this PR a regex is used for separation.

Changes proposed in this pull request:

  • use regex to match the top parent of json path of a placeholder

Related issue(s)

  • ...

Pull Request status

  • Implementation
  • Unit tests
  • Integration tests
  • chart/compass/values.yaml is updated
  • Mocks are regenerated, using the automated script

@kyma-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from emmakarova. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyma-bot kyma-bot added 🦅 team-falcon Team Falcon Label cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 13, 2024
@emmakarova emmakarova changed the title Fix processing of jsonpath for SLIS select criteria [HOTFIX] Fix processing of jsonpath for SLIS select criteria May 13, 2024
@dragobt dragobt self-assigned this May 15, 2024
@dragobt dragobt merged commit d9f54bf into hotfix-v1.94.0 May 15, 2024
5 of 6 checks passed
@dragobt dragobt deleted the fix-building-of-select-criteria-slis-request branch May 15, 2024 11:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Indicates the PR's author has signed the CLA. 🦅 team-falcon Team Falcon Label size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants