Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

Add formation templates label support #3861

Merged
merged 36 commits into from
May 14, 2024
Merged

Add formation templates label support #3861

merged 36 commits into from
May 14, 2024

Conversation

PetarTodorovv
Copy link
Collaborator

@PetarTodorovv PetarTodorovv commented May 8, 2024

Description
This PR adds CRUD functionalities for labels on the formation template entities.

Changes proposed in this pull request:

  • Add two new mutations - setFormationTemplateLabel and deleteFormationTemplateLabel that create/update and delete labels for formation templates respectively
  • Enrich the formation templates with the labels property and add labels sub-resolver
  • In the label package add support for the formation template entities
  • Add label filter support based on the newly introduced formation template labels
  • Split the current formation template input into two new inputs - one for registration and one for the update so the labels(and webhooks) can be only added initially on registration but not updated through the update mutations
  • Added created_at and updated_at timestamps to the formation templates
  • Adapt the current unit tests and add a new ones
  • Some of the E2E tests are adapted to create formation templates with labels and assert them
  • Fixes/adaptations in the E2E fixtures

Related issue(s)

  • ...

Pull Request status

  • Implementation
  • Unit tests
  • Integration tests
  • chart/compass/values.yaml is updated
  • Mocks are regenerated, using the automated script

@PetarTodorovv PetarTodorovv self-assigned this May 8, 2024
@PetarTodorovv PetarTodorovv requested review from a team as code owners May 8, 2024 06:40
@kyma-bot kyma-bot added the 🦖 team-raptor Team Raptor Label label May 8, 2024
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 8, 2024
@PetarTodorovv PetarTodorovv changed the title Add label support to formation templates Add formation templates label support May 8, 2024
@kyma-bot kyma-bot added lgtm Looks good to me! approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 13, 2024
@kyma-bot kyma-bot removed lgtm Looks good to me! approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 13, 2024
@kyma-bot
Copy link

@PetarTodorovv: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-compass-gke-benchmark 6bf8ed4 link false /test pre-main-compass-gke-benchmark

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyma-bot kyma-bot added lgtm Looks good to me! approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 14, 2024
@PetarTodorovv PetarTodorovv removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 14, 2024
@kyma-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivantenevvasilev, Peteva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyma-bot kyma-bot merged commit 829062d into main May 14, 2024
9 checks passed
@PetarTodorovv PetarTodorovv deleted the labelable-ft branch May 14, 2024 08:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. 🦖 team-raptor Team Raptor Label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants