Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

Prow removal #3854

Merged
merged 7 commits into from
May 13, 2024
Merged

Prow removal #3854

merged 7 commits into from
May 13, 2024

Conversation

ognyvrac
Copy link
Contributor

Description
Remove charts and scripts that will be moved internally.

Changes proposed in this pull request:

  • delete charts
  • keep some scripts needed for schema-migrator jobs
  • adapt director run.sh
  • schema-validate job always builds image

Related issue(s)

  • ...

Pull Request status

  • Implementation
  • Unit tests
  • Integration tests
  • chart/compass/values.yaml is updated
  • Mocks are regenerated, using the automated script

@ognyvrac ognyvrac requested review from a team as code owners April 26, 2024 10:05
@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. labels Apr 26, 2024
@kyma-bot kyma-bot added 🦅 team-falcon Team Falcon Label 🦖 team-raptor Team Raptor Label size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 26, 2024
@kyma-bot
Copy link

kyma-bot commented May 7, 2024

@ognyvrac: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-compass-gke-benchmark 3e30849 link false /test pre-main-compass-gke-benchmark
pre-main-compass-integration-no-dump 3e30849 link true /test pre-main-compass-integration-no-dump
pre-main-compass-smoke-test 3e30849 link true /test pre-main-compass-smoke-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ognyvrac ognyvrac changed the title [WIP] Prow removal Prow removal May 13, 2024
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 13, 2024
alexpenev-s
alexpenev-s previously approved these changes May 13, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 13, 2024
@ognyvrac
Copy link
Contributor Author

/check-required-labels

dzahariev
dzahariev previously approved these changes May 13, 2024
View reviewed changes
@ognyvrac ognyvrac dismissed stale reviews from dzahariev and alexpenev-s via f2abf62 May 13, 2024 11:26
@kyma-bot kyma-bot removed the lgtm Looks good to me! label May 13, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 13, 2024
@kyma-bot kyma-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024
ekaterina-mitova
ekaterina-mitova approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@ekaterina-mitova ekaterina-mitova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@kyma-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexpenev-s, dzahariev, ekaterina-mitova, PetarTodorovv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyma-bot kyma-bot merged commit b1ab143 into main May 13, 2024
5 of 6 checks passed
@ognyvrac ognyvrac deleted the prow-removal branch May 13, 2024 16:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PetarTodorovv PetarTodorovv PetarTodorovv approved these changes

@ekaterina-mitova ekaterina-mitova ekaterina-mitova approved these changes

@alexpenev-s alexpenev-s alexpenev-s approved these changes

@dzahariev dzahariev dzahariev approved these changes

@alextargov alextargov Awaiting requested review from alextargov

@DimitarPetrov DimitarPetrov Awaiting requested review from DimitarPetrov

Assignees

@dzahariev dzahariev

@alexpenev-s alexpenev-s

@ekaterina-mitova ekaterina-mitova

@PetarTodorovv PetarTodorovv

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. 🦅 team-falcon Team Falcon Label lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. 🦖 team-raptor Team Raptor Label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ognyvrac @kyma-bot @dzahariev @alexpenev-s @ekaterina-mitova @PetarTodorovv